jobs: Unify all options under CLUSTER_VARIANT #6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
fips, proxy, mirror, compact, and ovn should all be variants.
smarterclayton
force-pushed
the
unify_variants
branch
from
f336b2b to
8176a42
Compare
smarterclayton
added
lgtm
Contributor
Author
|
/test all |
Contributor
|
@smarterclayton: Updated the following 16 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 12, 2020
CLUSTER_NETWORK_TYPE is from ade608f (templates: allow overriding networkType, 2019-08-13, openshift#4295). But we've had ovn in CLUSTER_VARIANT since 8176a42 (jobs: Unify all options under CLUSTER_VARIANT, 2019-11-25, openshift#6077). Drop CLUSTER_NETWORK_TYPE (which was only set by e2e-gcp-ovn-upgrade jobs) and use CLUSTER_VARIANT instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fips, proxy, mirror, compact, and ovn should all be variants.