Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Jan 10, 2025

In CI, we want to collect an installer log bundle so we can examine bootstrap logs that aren't retrievable from anywhere else. This is especially important for problems that might happen during early install.

Depends on openshift/installer#9355

@openshift-ci openshift-ci bot requested review from neisw and xueqzhan January 10, 2025 19:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@hector-vido
Copy link
Contributor

/retest

1 similar comment
@hector-vido
Copy link
Contributor

/retest

@stbenjam stbenjam changed the title Always collect bootstrap bundle during installation TRT-1949: Always collect bootstrap bundle during installation Jan 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2025

@stbenjam: This pull request references TRT-1949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

In CI, we want to collect an installer log bundle so we can examine bootstrap logs that aren't retrievable from anywhere else. This is especially important for problems that might happen during early install.

Depends on openshift/installer#9355

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam
Copy link
Member Author

/hold

Will rehearse when it's in a payload

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@stbenjam
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@stbenjam
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/master/e2e-metal-ipi-ovn-dualstack-local-gateway f986b6b link unknown /pj-rehearse pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-dualstack-local-gateway
ci/rehearse/openshift/origin/release-4.20/e2e-metal-ipi-ovn-dualstack-local-gateway f986b6b link unknown /pj-rehearse pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-dualstack-local-gateway
ci/rehearse/jianzhangbjz/learn-operator/master/learn-oo-test-aws f986b6b link unknown /pj-rehearse pull-ci-jianzhangbjz-learn-operator-master-learn-oo-test-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Jan 23, 2025

Seems like we can get this in now given that openshift/installer#9355 has merged? Or is this being held for another reason?

This would be useful in validating openshift/installer#9392.

@stbenjam stbenjam force-pushed the collect-gathers-install branch from f986b6b to 5b43b3f Compare January 24, 2025 13:20
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
@stbenjam
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

In CI, we want to collect an installer log bundle so we can examine
bootstrap logs that aren't retrievable from anywhere else. This is
especially important for problems that might happen during early
install.
@stbenjam stbenjam force-pushed the collect-gathers-install branch from 5b43b3f to e014069 Compare January 28, 2025 19:10
@stbenjam
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@stbenjam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-azure-file-csi-driver-release-4.10-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-okd-scos-e2e-aws-ovn openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.18-okd-scos-e2e-aws-ovn openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.20-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.19-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.18-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.17-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.16-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.15-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.14-e2e-azure-file-csi-extended openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.20-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.19-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.18-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.17-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.16-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.15-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.14-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.13-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.12-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.11-e2e-azure-file-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-master-e2e-azure-file-nfs-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.20-e2e-azure-file-nfs-csi openshift/azure-file-csi-driver presubmit Registry content changed
pull-ci-openshift-azure-file-csi-driver-release-4.19-e2e-azure-file-nfs-csi openshift/azure-file-csi-driver presubmit Registry content changed

A total of 24892 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam
Copy link
Member Author

/hold cancel

Metal works now

2025-01-28 15:03:04 level=info msg=OPENSHIFT_INSTALL_GATHER_BOOTSTRAP is set, will attempt to gather a log bundle

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@stbenjam
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@stbenjam: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 28, 2025
@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, patrickdillon, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 174bcad into openshift:master Jan 29, 2025
11 checks passed
fjglira pushed a commit to fjglira/release that referenced this pull request Feb 5, 2025
In CI, we want to collect an installer log bundle so we can examine
bootstrap logs that aren't retrievable from anywhere else. This is
especially important for problems that might happen during early
install.
jtaleric pushed a commit to jtaleric/release that referenced this pull request Feb 10, 2025
In CI, we want to collect an installer log bundle so we can examine
bootstrap logs that aren't retrievable from anywhere else. This is
especially important for problems that might happen during early
install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants