Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ARO cluster with pre-existing network security group. #57548

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Create ARO cluster with pre-existing network security group. #57548

wants to merge 5 commits into from
+125 −1

Conversation

mgahagan73
Copy link
Contributor

Create ARO cluster with pre-existing network security group.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@mgahagan73
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-aro

@openshift-ci-robot
Copy link
Contributor

@mgahagan73: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgahagan73
Once this PR has been reviewed and has the lgtm label, please assign jianlinliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@mgahagan73
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-azure-aro

@openshift-ci-robot
Copy link
Contributor

@mgahagan73: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mgahagan73: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-node-density-cni-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
periodic-ci-redhat-chaos-prow-scripts-main-4.15-nightly-krkn-hub-tests-aro-415 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-aro-4.14-aro-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-aro-4.14-aro-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-azure-aro N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-aro N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay310-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-aro-4.13-aro-f7 N/A periodic Registry content changed
periodic-ci-redhat-chaos-prow-scripts-main-4.17-nightly-krkn-hub-tests-aro N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-azure-aro N/A periodic Ci-operator config changed
periodic-ci-redhat-chaos-prow-scripts-main-4.16-nightly-krkn-hub-tests-aro-416 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-aro-4.12-aro-f7 N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay312-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-control-plane-6nodes N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-aro-4.14-aro-f28 N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay311-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-node-density-heavy-6nodes N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgahagan73
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-azure-aro

@openshift-ci-robot
Copy link
Contributor

@mgahagan73: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Oct 8, 2024

@jinyunma could you help review the pr? thanks

jianlinliu
jianlinliu reviewed Oct 8, 2024
View reviewed changes
ci-operator/step-registry/aro/provision/nsg/aro-provision-nsg-commands.sh
AZURE_AUTH_CLIENT_SECRET="$(<"${AZURE_AUTH_LOCATION}" jq -r .clientSecret)"
AZURE_AUTH_TENANT_ID="$(<"${AZURE_AUTH_LOCATION}" jq -r .tenantId)"
MASTER_SUBNET_NAME=${MASTER_SUBNET_NAME:=$(grep controlPlaneSubnet ${SHARED_DIR}/customer_vnet_subnets.yaml | cut -d ":" -f 2 | tr -d "[:blank:]")}
WORKER_SUBNET_NAME=${WORKER_SUBNET_NAME:=$(grep computeSubnet ${SHARED_DIR}/customer_vnet_subnets.yaml | cut -d ":" -f 2 | tr -d "[:blank:]")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WORKER_SUBNET_NAME=${WORKER_SUBNET_NAME:=$(grep computeSubnet ${SHARED_DIR}/customer_vnet_subnets.yaml | cut -d ":" -f 2 | tr -d "[:blank:]")}
MASTER_SUBNET_NAME=$(yq-go r ${SHARED_DIR}/customer_vnet_subnets.yaml 'platform.azure.controlPlaneSubnet')
WORKER_SUBNET_NAME=$(yq-go r ${SHARED_DIR}/customer_vnet_subnets.yaml 'platform.azure.computeSubnet')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@MayXuQQ MayXuQQ Awaiting requested review from MayXuQQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgahagan73 @openshift-ci-robot @MayXuQQ @jianlinliu