Skip to content

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Jul 24, 2024

We recently had to revert a csi-external-provisioner rebase because it broke on vsphere. This PR adds a presubmit job for vsphere to the csi-external-provisioner repo to catch this kind of thing earlier.

/cc @openshift/storage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

We recently had to revert a csi-external-provisioner rebase because it broke on vsphere. This PR adds a presubmit job for vsphere to the csi-external-provisioner repo to catch this kind of thing earlier.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dobsonj: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-external-provisioner-master-e2e-vsphere-csi openshift/csi-external-provisioner presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 24, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@dobsonj: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 24, 2024

The rehearsal should actually fail until openshift/csi-external-provisioner#102 merges

@gnufied
Copy link
Member

gnufied commented Jul 24, 2024

ha I also opened - #54789

So this PR in itself will not catch intree PV deletion failing bug, because if you see - openshift/vmware-vsphere-csi-driver-operator#241 then vsphere-csi test suite actually is passing, but it is generic e2e-vsphere that is failing.

@dobsonj
Copy link
Member Author

dobsonj commented Jul 24, 2024

/close
in favor of #54789

@openshift-ci openshift-ci bot closed this Jul 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@dobsonj: Closed this PR.

Details

In response to this:

/close
in favor of #54789

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants