-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add e2e-vsphere-csi to csi-external-provisioner presubmit jobs #54790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e-vsphere-csi to csi-external-provisioner presubmit jobs #54790
Conversation
|
@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@dobsonj: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
The rehearsal should actually fail until openshift/csi-external-provisioner#102 merges |
|
ha I also opened - #54789 So this PR in itself will not catch intree PV deletion failing bug, because if you see - openshift/vmware-vsphere-csi-driver-operator#241 then vsphere-csi test suite actually is passing, but it is generic |
|
/close |
|
@dobsonj: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We recently had to revert a csi-external-provisioner rebase because it broke on vsphere. This PR adds a presubmit job for vsphere to the csi-external-provisioner repo to catch this kind of thing earlier.
/cc @openshift/storage