Skip to content

MULTIARCH-4769 Day 0 multiarch compute arm x86 #54129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jul 10, 2024
Merged

MULTIARCH-4769 Day 0 multiarch compute arm x86 #54129

openshift-merge-bot merged 1 commit into from
Jul 10, 2024

Conversation

@tvardema
Copy link
Contributor

@tvardema tvardema commented Jul 8, 2024

The multiarch team is working on an installer PR to enable day-0 multiarch compute deployments. This PR enables this on AWS.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
@openshift-ci openshift-ci bot requested review from DennisPeriquet and bfournie July 8, 2024 20:37
@tvardema tvardema force-pushed the MULTIARCH-4769-multiarch-compute-day-0-arm-x86-aws branch 2 times, most recently from a50828b to b69bbeb Compare July 9, 2024 16:17
@tvardema
MULTIARCH-4769 Day 0 multiarch compute arm x86
a455e98 
The multiarch team is working on an installer PR to enable day-0 multiarch compute deployments.
This PR enables this on AWS.
@tvardema tvardema force-pushed the MULTIARCH-4769-multiarch-compute-day-0-arm-x86-aws branch from b69bbeb to a455e98 Compare July 9, 2024 16:25
@r4f4
Copy link
Contributor

r4f4 commented Jul 9, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous
Expected to fail until openshift/installer#8698 merges. Failing is a good sign in this PR.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2024

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2024

[REHEARSALNOTIFIER]
@tvardema: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-medik8s-customized-user-remediation-main-4.16-openshift-e2e medik8s/customized-user-remediation presubmit Registry content changed
pull-ci-medik8s-customized-user-remediation-main-4.17-openshift-e2e medik8s/customized-user-remediation presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-master-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.18-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.17-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.16-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.15-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.14-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.13-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.12-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.11-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.10-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.9-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.8-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.7-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.6-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.5-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.4-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.3-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.2-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-descheduler-operator-release-4.1-e2e-aws-operator openshift/cluster-kube-descheduler-operator presubmit Registry content changed
pull-ci-openshift-knative-eventing-hyperfoil-benchmark-main-414-test-kafka-broker-midstr-a0cb886-aws-414 openshift-knative/eventing-hyperfoil-benchmark presubmit Registry content changed
pull-ci-openshift-knative-eventing-hyperfoil-benchmark-main-414-test-kafka-broker-upstre-fbbddbf-aws-414 openshift-knative/eventing-hyperfoil-benchmark presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.5-e2e-operator openshift/aws-ebs-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-aws-ebs-csi-driver-operator-release-4.14-e2e-aws-csi openshift/aws-ebs-csi-driver-operator presubmit Registry content changed

A total of 10143 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@r4f4
Copy link
Contributor

r4f4 commented Jul 9, 2024

Expected to fail until openshift/installer#8698 merges. Failing is a good sign in this PR.

Failed as expected:

level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: invalid "install-config.yaml" file: compute[0].architecture: Invalid value: "amd64": heteregeneous multi-arch is not supported; compute pool architecture must match control plane
Create manifests exit code: 3

The install-config.yaml has the right instance types and arches for each node type.

@tvardema
Copy link
Contributor Author

tvardema commented Jul 9, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.17-ocp-e2e-aws-ovn-heterogeneous periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-fips pull-ci-openshift-cluster-config-operator-release-4.14-e2e-aws-ovn pull-ci-openshift-cluster-kube-descheduler-operator-release-4.17-e2e-aws-operator

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2024

@tvardema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tvardema tvardema changed the title WIP - MULTIARCH-4769 Day 0 multiarch compute arm x86 MULTIARCH-4769 Day 0 multiarch compute arm x86 Jul 9, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2024
@tvardema
Copy link
Contributor Author

tvardema commented Jul 9, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2024

@tvardema: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 9, 2024
r4f4
r4f4 reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@r4f4 r4f4 mentioned this pull request Jul 9, 2024
Merged
3 tasks
@r4f4
Copy link
Contributor

r4f4 commented Jul 9, 2024

/pj-rehearse periodic-ci-openshift-multiarch-master-nightly-4.16-ocp-e2e-aws-ovn-arm64

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2024

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@tvardema: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-ovn-heterogeneous a455e98 link unknown /pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-heterogeneous

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xueqzhan
Copy link
Contributor

xueqzhan commented Jul 10, 2024

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4, tvardema, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit afb2462 into openshift:master Jul 10, 2024
@tvardema tvardema deleted the MULTIARCH-4769-multiarch-compute-day-0-arm-x86-aws branch July 10, 2024 15:41
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
@tvardema
MULTIARCH-4769 Day 0 multiarch compute arm x86 (openshift#54129)
7333cb0 
The multiarch team is working on an installer PR to enable day-0 multiarch compute deployments.
This PR enables this on AWS.
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
@tvardema @Neha-dot-Yadav
MULTIARCH-4769 Day 0 multiarch compute arm x86 (openshift#54129)
cef3703 
The multiarch team is working on an installer PR to enable day-0 multiarch compute deployments.
This PR enables this on AWS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@DennisPeriquet DennisPeriquet Awaiting requested review from DennisPeriquet

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@r4f4 r4f4

@xueqzhan xueqzhan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvardema @r4f4 @openshift-ci-robot @xueqzhan