Skip to content

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 3, 2024

@ashwindasr ashwindasr force-pushed the api-rename-dockerfile branch from 118fddd to c7a5085 Compare July 10, 2024 18:15
@ashwindasr
Copy link
Contributor Author

/label tide/squash-and-merge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@ashwindasr: The label(s) /label tide/squash-and-merge cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label tide/squash-and-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashwindasr
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 10, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@ashwindasr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-build openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-aws-ovn openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-aws-ovn-hypershift openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-aws-ovn-techpreview openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-aws-serial openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-aws-serial-techpreview openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-azure openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-gcp openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-upgrade openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-e2e-upgrade-minor openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-images openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-integration openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-okd-scos-images openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-unit openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-verify openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-verify-client-go openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-verify-crd-schema openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-verify-deps openshift/api presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@JoelSpeed
Copy link
Contributor

/lgtm
/hold

Discussed with Ashwin, needs to be co-ordinated with an API repo merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@ashwindasr
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@ashwindasr
Copy link
Contributor Author

/hold

@JoelSpeed looks like we need the rehearsals-ack label as well.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@JoelSpeed
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@JoelSpeed: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 11, 2024
@ashwindasr
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e9532e9 into openshift:master Jul 11, 2024
@ashwindasr ashwindasr deleted the api-rename-dockerfile branch July 11, 2024 16:19
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
* [api] Rename dockerfile

* run make jobs
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Jul 19, 2024
* [api] Rename dockerfile

* run make jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants