Skip to content

Move vsphere periodic job to release-next branch, remove from 0.8.1 branch. #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markusthoemmes wants to merge 1 commit into from
Closed

Move vsphere periodic job to release-next branch, remove from 0.8.1 branch. #5367

markusthoemmes wants to merge 1 commit into from

Conversation

@markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Oct 10, 2019

As per title, this moves the periodic vsphere job over to the release-next branch.

Also tries to circumvent make based problems by sidestepping it.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 10, 2019
@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 10, 2019

Failures are expected due to the canonical_go_repository but in rehearsals.

mgencur
mgencur reviewed Oct 10, 2019
View reviewed changes
Copy link
Contributor

@mgencur mgencur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @markusthoemmes I left one comment which probably needs clarification.

...erator/jobs/openshift/knative-serving/openshift-knative-serving-release-next-presubmits.yaml Outdated
Copy link
Contributor

@mgencur mgencur Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this whole thing will work because of this template. For other Knative tests we use https://github.com/openshift/release/blob/master/ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml which uses this image to execute our tests: https://github.com/openshift/release/blob/master/ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml#L15 . It needs to actually include our source. The upi-e2e.yaml template seems to use a different image and I suppose it will only include OpenShift test suite, not Knative sources/test suites. Better to check with @stevekuznetsov or @petr-muller

Copy link
Member

@petr-muller petr-muller Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the cluster-launch-installer-upi-e2e template, but what @mgencur says is correct - it would be probably a good idea to get in touch with whoever wrote/owns that template and check if it's able to do what you expect to do.

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Oct 10, 2019

/test pj-rehearse

1 similar comment
@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 11, 2019

/test pj-rehearse

@markusthoemmes markusthoemmes force-pushed the knative-release-next-vsphere branch from 348957a to e68ae2f Compare October 11, 2019 07:31
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2019
@markusthoemmes markusthoemmes force-pushed the knative-release-next-vsphere branch from e68ae2f to 09bfcf7 Compare October 16, 2019 08:32
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 16, 2019

/test pj-rehearse

7 similar comments
@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 16, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 16, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 16, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 16, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 17, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 17, 2019

/test pj-rehearse

@markusthoemmes
Copy link
Contributor Author

markusthoemmes commented Oct 21, 2019

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 21, 2019

@markusthoemmes: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-knative-serving-release-next-vsphere-e2e-vsphere-ocp-42 889462a2884be8039711af09b6df83ef5b2866b5 link /test pj-rehearse
ci/rehearse/openshift/knative-serving/release-next/vsphere-e2e-vsphere-ocp-42 09bfcf7 link /test pj-rehearse
ci/prow/pj-rehearse 09bfcf7 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgencur mgencur mentioned this pull request Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arilivigni arilivigni Awaiting requested review from arilivigni

@jcrossley3 jcrossley3 Awaiting requested review from jcrossley3

2 more reviewers

@mgencur mgencur mgencur left review comments

@petr-muller petr-muller petr-muller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markusthoemmes @stevekuznetsov @openshift-ci-robot @mgencur @petr-muller