Skip to content

ipifmw #52948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgoveas wants to merge 3 commits into from
Closed

ipifmw #52948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91a990f
Add upi primaryv6 job
sgoveas Feb 11, 2026
393c68f
skip test, use baremetal-qe-base for wait
sgoveas Dec 16, 2025
26d0a6e
test 857
sgoveas Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions ...penshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6018,6 +6018,21 @@ tests:
test:
- chain: openshift-e2e-test-qe
workflow: baremetal-lab-upi-dual-stack
- as: metal-upi-ovn-dualstack-primaryv6-f7
capabilities:
- intranet
cron: 20 13 4,13,20,27 * *
steps:
cluster_profile: equinix-ocp-metal-qe
env:
AUX_HOST: openshift-qe-metal-ci.arm.eng.rdu2.redhat.com
PRIMARY_NET: ipv6
architecture: amd64
masters: "3"
workers: "2"
test:
- chain: openshift-e2e-test-qe
workflow: baremetal-lab-upi-dual-stack
Comment on lines +6033 to +6035

@coderabbitai coderabbitai Bot Apr 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read-only verification: inspect active (non-commented) steps in openshift-e2e-test-qe chain.

CHAIN_FILE="$(fd -a 'openshift-e2e-test-qe-chain.yaml' | head -n1)"
echo "Chain file: $CHAIN_FILE"
echo

echo "== Active steps =="
rg -n '^\s*-\s*(ref|chain):' "$CHAIN_FILE"

echo
echo "== Commented-out steps (if any) =="
rg -n '^\s*#\s*-\s*(ref|chain):' "$CHAIN_FILE" || true

echo
echo "== File excerpt =="
nl -ba "$CHAIN_FILE" | sed -n '1,220p'

Repository: openshift/release

Length of output: 726

Enable substantive QE tests in openshift-e2e-test-qe chain before merging.

The openshift-e2e-test-qe chain currently only executes cucushift-installer-check-cluster-health. All substantive QE test steps are commented out:

  • openshift-extended-test
  • cucushift-e2e
  • openshift-extended-test-supplementary
  • openshift-e2e-test-clusterinfra-qe
  • and others

The four newly added jobs depend on this chain to validate UPI/IPI IPv6/TechPreview behavior. Without uncommenting these test steps, the periodic jobs will only run health checks and won't fulfill their intended purpose.

Also applies to: 5490-5491, 5505-5506, 5521-5523

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yaml`
around lines 5390 - 5392, The openshift-e2e-test-qe chain currently only runs
the health check (cucushift-installer-check-cluster-health) while substantive QE
tests (openshift-extended-test, cucushift-e2e,
openshift-extended-test-supplementary, openshift-e2e-test-clusterinfra-qe, etc.)
are commented out; before merging the new jobs that rely on this chain (e.g.,
workflows like baremetal-lab-upi-dual-stack), uncomment and restore those
substantive test steps in the openshift-e2e-test-qe chain so the periodic
UPI/IPI IPv6/TechPreview validations actually execute, and verify that the four
new jobs reference the restored chain and required test steps
(openshift-extended-test, cucushift-e2e, openshift-extended-test-supplementary,
openshift-e2e-test-clusterinfra-qe) are present and enabled.

- as: metal-upi-ovn-ipsec-ipv6-fips-f7
capabilities:
- intranet
Expand Down Expand Up @@ -6120,6 +6135,38 @@ tests:
test:
- chain: openshift-e2e-test-hypershift-qe
workflow: cucushift-installer-rehearse-azure-hypershift
- as: metal-ipi-ovn-dualstack-vmedia-f7
capabilities:
- intranet
cron: 3 13 6,15,22,29 * *
steps:
cluster_profile: equinix-ocp-metal-qe
env:
AUX_HOST: openshift-qe-metal-ci.arm.eng.rdu2.redhat.com
PRIMARY_NET: ipv6
RESERVE_BOOTSTRAP: "false"
architecture: amd64
ipv6_enabled: "true"
masters: "3"
workers: "2"
test:
- chain: openshift-e2e-test-qe
workflow: baremetal-lab-ipi-virtual-media
- as: metal-ipi-ovn-ipv6-static-vmedia-f14
capabilities:
- intranet
cron: 46 21 9,25 * *
steps:
cluster_profile: equinix-ocp-metal-qe
env:
AUX_HOST: openshift-qe-metal-ci.arm.eng.rdu2.redhat.com
RESERVE_BOOTSTRAP: "false"
architecture: amd64
masters: "3"
workers: "2"
test:
- chain: openshift-e2e-test-qe
workflow: baremetal-lab-ipi-virtual-media-ipv6-static
zz_generated_metadata:
branch: release-4.22
org: openshift
Expand Down
3 changes: 3 additions & 0 deletions ci-operator/step-registry/baremetal/lab/ipi/install/baremetal-lab-ipi-install-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ INSTALL_DIR="/tmp/installer"
BASE_DOMAIN=$(<"${CLUSTER_PROFILE_DIR}/base_domain")
CLUSTER_NAME=$(<"${SHARED_DIR}/cluster_name")

export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="registry.build10.ci.openshift.org/ci-ln-299kd42/release:latest"
export MULTI_RELEASE_IMAGE="registry.build10.ci.openshift.org/ci-ln-299kd42/release:latest"

echo "[INFO] Installing from initial release ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}..."
echo "[INFO] Extracting the baremetal-installer from ${MULTI_RELEASE_IMAGE}..."
echo "[INFO] Set OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY to true for nightly payload"
Expand Down
5 changes: 3 additions & 2 deletions ci-operator/step-registry/baremetal/lab/post/baremetal-lab-post-chain.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
chain:
as: baremetal-lab-post
steps:
- ref: baremetal-lab-agent-gather
- chain: gather
# - ref: baremetal-lab-agent-gather
# - chain: gather
- ref: baremetal-lab-wait
- ref: baremetal-lab-post-dhcp-pxe-conf
- ref: baremetal-lab-post-wipe
- ref: baremetal-lab-post-dns
Expand Down
7 changes: 5 additions & 2 deletions ci-operator/step-registry/baremetal/lab/wait/baremetal-lab-wait-ref.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
ref:
as: baremetal-lab-wait
from: cli
from_image:
namespace: ci
name: "baremetal-qe-base"
tag: latest
commands: baremetal-lab-wait-commands.sh
resources:
requests:
Expand All @@ -9,7 +12,7 @@ ref:
timeout: 72h
env:
- name: CLUSTER_DURATION
default: "9000"
default: "259200"
documentation: >-
This configures how long this step waits for in seconds.
documentation: >-
Expand Down
20 changes: 10 additions & 10 deletions ci-operator/step-registry/openshift/e2e/test/qe/openshift-e2e-test-qe-chain.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ chain:
as: openshift-e2e-test-qe
steps:
- chain: cucushift-installer-check-cluster-health
- ref: idp-htpasswd
- ref: fips-check-fips-or-die
- ref: fips-check-node-scan
- ref: cucushift-pre
- ref: openshift-extended-test
- ref: cucushift-e2e
- ref: openshift-extended-web-tests
- ref: openshift-extended-test-supplementary
- ref: openshift-e2e-test-clusterinfra-qe
- ref: openshift-e2e-test-qe-report
# - ref: idp-htpasswd
# - ref: fips-check-fips-or-die
# - ref: fips-check-node-scan
# - ref: cucushift-pre
# - ref: openshift-extended-test
# - ref: cucushift-e2e
# - ref: openshift-extended-web-tests
# - ref: openshift-extended-test-supplementary
# - ref: openshift-e2e-test-clusterinfra-qe
# - ref: openshift-e2e-test-qe-report
documentation: |-
Execute e2e tests from QE, which include golang (openshift-extended-test), cucushift (cucushift-e2e), cypress (openshift-extended-web-tests), ...(more to add)