Add Golang 1.13.1 to CI. #5236
Merged
Add Golang 1.13.1 to CI. #5236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Contributor
Author
|
/assign @bbguimaraes |
matzew
reviewed
Oct 1, 2019
| @@ -0,0 +1,21 @@ | |||
| Name: golang | |||
| Version: v1.13.0 | |||
Contributor
Author
There was a problem hiding this comment.
Compare with the 1.12 file. This is for building fake RPMs only and it has been kept at 1.12.0 as well although the version is actually at 1.12.9 now.
Member
There was a problem hiding this comment.
ah... does not make sense, but ok :-)
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 16, 2019
We need this to bump a Terraform provider [1], which we need to fix an AWS provisioning flake [2]. golang-1.13 became available in CI in 407b8e0 (Add Golang 1.13.1 to CI, 2019-10-01, openshift#5236). Skipping 4.3 [3,4] (which is in code-freeze). [1]: openshift/installer#2676 (comment) [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1759617#c10 [3]: openshift#5928 (comment) [4]: openshift#5928 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.13.1 is the current stable version of Golang.
The Knative project is adopting Golang 1.13 and its improvements, hence we need this to be able to keep up with upstream and run it through CI.