Skip to content

Adjust to TokenRequest API for external cluster kubeconfig #52229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 20, 2024
Merged

Adjust to TokenRequest API for external cluster kubeconfig #52229

openshift-merge-bot merged 1 commit into from
May 20, 2024

Conversation

@orenc1
Copy link
Contributor

@orenc1 orenc1 commented May 20, 2024 •
edited
Loading

in OCP 4.16, service accounts are no longer created with a token secret with them. instead, we need to explicitly request from the API server to create a token for the given ServiceAccount. this PR accommodates this change in the create-external-infra-kubeconfig step in hypershift-kubevirt presubmit e2e workflow.

@orenc1
Adjust to TokenRequest API for external cluster kubeconfig
d683a5a 
in OCP 4.16, service accounts are no longer created with a token secret with them.
instead, we need to explicitly request from the API server to create a token for the given ServiceAccount.
this PR accomodates this change in the 'create-external-infra-kubeconfig' step in hypershift-kubevirt presubmit e2e workflow

Signed-off-by: Oren Cohen <ocohen@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2024

[REHEARSALNOTIFIER]
@orenc1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.15-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.14-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.13-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-main-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.17-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.16-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.15-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-api-provider-kubevirt-release-4.14-e2e-hypershift-kubevirt openshift/cluster-api-provider-kubevirt presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

davidvossel
davidvossel reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot requested review from nirarg and qinqon May 20, 2024 15:22
davidvossel
davidvossel reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@davidvossel
Copy link
Contributor

davidvossel commented May 20, 2024

/pj-rehearse pull-ci-openshift-hypershift-release-4.15-e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2024

@davidvossel: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@orenc1
Copy link
Contributor Author

orenc1 commented May 20, 2024

the change in this PR is working, as per:
INFO[2024-05-20T18:02:05Z] Step e2e-kubevirt-aws-ovn-hypershift-kubevirt-install-create-external-infra-kubeconfig succeeded after 10s.
thus,
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2024

@orenc1: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 64b3e0c into openshift:master May 20, 2024
@orenc1 orenc1 deleted the hs-kv_adjust_to_token_request_api branch May 20, 2024 18:15
@orenc1 orenc1 mentioned this pull request May 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirarg nirarg Awaiting requested review from nirarg

@qinqon qinqon Awaiting requested review from qinqon

1 more reviewer

@davidvossel davidvossel davidvossel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@davidvossel davidvossel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orenc1 @openshift-ci-robot @davidvossel