Bug 1753032: cluster-launch-installer-upi-e2e: vsphere upi: Add bootstrap gather #5060
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/test e2e-vsphere |
- Gathers the bootstrap and control plane ip address to set GATHER_BOOTSTRAP_ARGS
jcpowermac
force-pushed
the
vsphere_gather_bootstrap
branch
from
57f686b to
d5f41b3
Compare
jcpowermac
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@jcpowermac: This pull request references Bugzilla bug 1753032, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| wait "$!" | ||
| # find bootstrap ip | ||
| BOOTSTRAP_IP=$(terraform state show 'module.bootstrap.external.ip_address' | grep ip_address | awk '{print $3}') |
There was a problem hiding this comment.
You have jq in this container; I'd prefer that over grep and awk. But I like using ... state show ... too. Looks like new Terraforms support -json since v0.12.0. Can we bump our current 0.11.11 pin to pick up a newer Terraform and use that?
There was a problem hiding this comment.
Ah, a bump to v0.12.0 is in-flight, but it's complicated (openshift/installer#2057). We'll circle back to this once we get that landed.
/lgtm
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jcpowermac: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcpowermac: All pull requests linked via external trackers have merged. Bugzilla bug 1753032 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
/hold