Skip to content

Conversation

@stevekuznetsov
Copy link
Contributor

We are not rehearsing any jobs for repositories with many presubmits,
which is the opposite of what we want to be doing. In general we should
not worry about starting a thundering herd if all jobs belong to one
configuration, as any new pull request to the same repository will
trigger the same set of jobs normally.

Signed-off-by: Steve Kuznetsov [email protected]

We are not rehearsing any jobs for repositories with many presubmits,
which is the opposite of what we want to be doing. In general we should
not worry about starting a thundering herd if all jobs belong to one
configuration, as any new pull request to the same repository will
trigger the same set of jobs normally.

Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit d0ff25a into openshift:master Aug 19, 2019
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Updated the job-config-master-presubmits configmap in namespace ci using the following files:

  • key openshift-release-master-presubmits.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml
Details

In response to this:

We are not rehearsing any jobs for repositories with many presubmits,
which is the opposite of what we want to be doing. In general we should
not worry about starting a thundering herd if all jobs belong to one
configuration, as any new pull request to the same repository will
trigger the same set of jobs normally.

Signed-off-by: Steve Kuznetsov [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-release that referenced this pull request Oct 20, 2020
Folks have been tuning this since b0d60e3 (Bump the limit of
rehearsed jobs, 2019-08-19, openshift#4789), most recently in 3f0040e (Raise
rehearsal-limit to 45 temporarily, 2020-02-03, openshift#6999).  But with [1],
we no longer need to fuss with this setting in order to see rehearsals
for changes that touch lots of jobs, so let it fall back to
pj-rehearse's default of 15.

[1]: openshift/ci-tools#1315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants