Skip to content

logging - add simple upgrade job #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 20, 2019
Merged

logging - add simple upgrade job #4788

openshift-merge-robot merged 1 commit into from
Sep 20, 2019

Conversation

@richm
Copy link
Contributor

@richm richm commented Aug 19, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2019
@richm richm changed the title add simple upgrade job logging - add simple upgrade job Aug 19, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@richm
Copy link
Contributor Author

richm commented Aug 19, 2019

/ci/rehearse/openshift/origin-aggregated-logging/master/upgrade-full-integ-aws

@richm
Copy link
Contributor Author

richm commented Aug 19, 2019

/test ci/rehearse/openshift/origin-aggregated-logging/master/upgrade-full-integ-aws

@richm
Copy link
Contributor Author

richm commented Aug 19, 2019

/test pj-rehearse

3 similar comments
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 19, 2019

/test pj-rehearse

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 19, 2019

/test pj-rehearse

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 19, 2019

/test pj-rehearse

@richm
Copy link
Contributor Author

richm commented Aug 19, 2019

multi-tenancy flake
/retest

@richm
Copy link
Contributor Author

richm commented Aug 19, 2019

/retest

1 similar comment
@richm
Copy link
Contributor Author

richm commented Aug 20, 2019

/retest

@richm
Copy link
Contributor Author

richm commented Aug 20, 2019

flake
/retest

@richm
Copy link
Contributor Author

richm commented Aug 20, 2019

This looks like the flake problem that should be fixed by openshift/cluster-logging-operator#230
/retest

ewolinetz
ewolinetz reviewed Aug 22, 2019
View reviewed changes
...enshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master-presubmits.yaml
name: cluster-profile
- mountPath: /usr/local/upgrade-full-integ-aws
name: job-definition
subPath: cluster-launch-installer-src.yaml
Copy link
Contributor

@ewolinetz ewolinetz Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, do we have any other jobs that use this job template?

Copy link
Contributor Author

@richm richm Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - the full-integ-aws test uses this template

@ewolinetz
Copy link
Contributor

ewolinetz commented Aug 22, 2019

overall LGTM, just have a quick question

@ewolinetz
Copy link
Contributor

ewolinetz commented Sep 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 48a8403 into openshift:master Sep 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2019

@richm: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-origin-aggregated-logging-master.yaml using file ci-operator/config/openshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-origin-aggregated-logging-master.yaml using file ci-operator/config/openshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-origin-aggregated-logging-master-presubmits.yaml using file ci-operator/jobs/openshift/origin-aggregated-logging/openshift-origin-aggregated-logging-master-presubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richm richm deleted the logging-upgrade branch September 20, 2019 14:48
@wking wking mentioned this pull request Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill Awaiting requested review from jcantrill

1 more reviewer

@ewolinetz ewolinetz ewolinetz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ewolinetz ewolinetz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richm @openshift-merge-robot @ewolinetz @openshift-ci-robot