add openshift-ci-security workflow to OCP storage repos #47618
Conversation
|
@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse max |
|
/hold to fix these issues before merging this |
openshift-ci
bot
added
the
do-not-merge/hold
|
I opened PR's to ignore most of the false positives: |
dobsonj
force-pushed
the
ocp-storage-security-presubmits
branch
from
4dfd83a to
227d6a1
Compare
|
/pj-rehearse max |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/pj-rehearse pull-ci-openshift-local-storage-operator-master-security |
|
/pj-rehearse pull-ci-openshift-cluster-storage-operator-master-e2e-openstack |
openshift-merge-robot
added
the
needs-rebase
|
@duanwei33, |
dobsonj
force-pushed
the
ocp-storage-security-presubmits
branch
from
227d6a1 to
6bb1cfe
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/pj-rehearse max |
|
Just the known issues remain, and those need to be fixed upstream. |
openshift-ci-robot
added
the
rehearsals-ack
The openshift-ci-security workflow exposed some false-positives in upstream code for gcp-filestore-csi-driver and node-driver-registrar. Set this job to always_run=false until we can get the issue fixed and this job passes consistently.
dobsonj
force-pushed
the
ocp-storage-security-presubmits
branch
from
6bb1cfe to
f556692
Compare
openshift-ci-robot
removed
the
rehearsals-ack
|
[REHEARSALNOTIFIER]
A total of 27 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test check-gh-automation-tide |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
|
/assign @deepsm007 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dobsonj, mpatlasov, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dobsonj: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dobsonj: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
) * make storage-approvers and storage-reviewers consistent * update storage team members for backport-risk-assessed label * add openshift-ci-security workflow to OCP storage repos * security: always_run=false for gcp-filestore and node-driver-registrar The openshift-ci-security workflow exposed some false-positives in upstream code for gcp-filestore-csi-driver and node-driver-registrar. Set this job to always_run=false until we can get the issue fixed and this job passes consistently.
8 participants
This adds the snyk security scan as a presubmit job. It should pass (if we successfully ignored all false positives).
Also some cleanup around storage owners.
/cc @openshift/storage