Skip to content

Add canary job for installer w/ OpenStack #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 24, 2019
Merged

Add canary job for installer w/ OpenStack #4712

openshift-merge-robot merged 1 commit into from
Aug 24, 2019

Conversation

@dprince
Copy link
Contributor

@dprince dprince commented Aug 12, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2019
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 12, 2019

if you add it like other canary https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/release/openshift-release-release-4.2-periodics.yaml you might be able to get it into the canary dashboard.

@dprince dprince force-pushed the periodic_openstack branch from 6090977 to bb46a9c Compare August 12, 2019 19:39
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2019
@dprince
Copy link
Contributor Author

dprince commented Aug 12, 2019

if you add it like other canary https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/release/openshift-release-release-4.2-periodics.yaml you might be able to get it into the canary dashboard.

Thanks, I've updated the PR to target the 4.2 periodics

@iamemilio
Copy link
Contributor

iamemilio commented Aug 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2019
@eparis
Copy link
Member

eparis commented Aug 15, 2019

/lgtm
But I think we need @smarterclayton

smarterclayton
smarterclayton reviewed Aug 15, 2019
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-master-periodics.yaml Outdated
Copy link
Contributor

@smarterclayton smarterclayton Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would normally be a release periodic, we put them together so you can track. Search for "canary-*" and you should see a bunch of canary-release-* jobs. Move this into there and give it consistent names.

Copy link
Contributor

@smarterclayton smarterclayton Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see you have a periodic here. Basically if you have a release periodic you shouldn't do a post submit. It'll show the same info but in a confusing way.

Copy link
Contributor Author

@dprince dprince Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to remove that from the last rebase (my first attempt here). Let me get rid of the post-commit job and just leave the periodic(canary) job.

smarterclayton
smarterclayton reviewed Aug 15, 2019
View reviewed changes
ci-operator/jobs/openshift/release/openshift-release-release-4.2-periodics.yaml Outdated
Copy link
Contributor

@smarterclayton smarterclayton Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long until this is fixed to run all e2e tests?

Copy link
Contributor Author

@dprince dprince Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on your question about tests this afternoon. The answer is I think we can try them now. The reason we ran minimal for some of the openstack pre/post submit jobs I think was solely to save time on those jobs.

@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 16, 2019

Two comments, looks fine otherwise

@dprince dprince force-pushed the periodic_openstack branch from bb46a9c to 0c94356 Compare August 16, 2019 00:50
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2019
@dprince
Copy link
Contributor Author

dprince commented Aug 16, 2019

Two comments, looks fine otherwise

I think I got them both address in this last rebase. Thanks

@dprince dprince changed the title Add periodic job for installer w/ OpenStack Add canary job for installer w/ OpenStack Aug 16, 2019
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 16, 2019

/test pj-rehearse

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 16, 2019

Please set the rehearsal label so you get feedback here:

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_release/4712/pull-ci-openshift-release-master-pj-rehearse/6157#0:build-log.txt%3A3

@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 16, 2019

Yeah, want to see rehearsal.

@dprince dprince force-pushed the periodic_openstack branch from 0c94356 to 1c60dea Compare August 19, 2019 12:25
@dprince
Copy link
Contributor Author

dprince commented Aug 19, 2019

/test pj-rehearse

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Aug 19, 2019

/test pj-rehearse

@dprince dprince force-pushed the periodic_openstack branch 2 times, most recently from 79baf41 to 41b2126 Compare August 22, 2019 12:14
@dprince
Copy link
Contributor Author

dprince commented Aug 22, 2019

/test pj-rehearse

@dprince
Copy link
Contributor Author

dprince commented Aug 22, 2019

The bootkube.log on the bootstrap has this: Error reading manifest 4.2 in registry.svc.ci.openshift.org/ocp/release: unauthorized: authentication required.

Maybe we need another pull-secret?

@dprince dprince force-pushed the periodic_openstack branch from 41b2126 to 45c085c Compare August 22, 2019 16:41
@dprince
Copy link
Contributor Author

dprince commented Aug 22, 2019

/test pj-rehearse

wking
wking reviewed Aug 22, 2019
View reviewed changes
ci-operator/jobs/openshift/release/openshift-release-release-4.2-periodics.yaml Outdated
Copy link
Member

@wking wking Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the usual OpenStack presubmit only has the profile secret. I don't understand how that works, but it seems like it does. Maybe try to get closer to that template, or try to get @flaper87 to explain why he didn't need the pull-secret entry in #1824?

Copy link
Contributor Author

@dprince dprince Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be related to the old "inline" nature of the secrets. I pushed this to align OpenStack with the latest attachements: #4823

Copy link
Contributor Author

@dprince dprince Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more observation would be what you said above applies to all the AWS jobs too. OpenStack is working in presubmit, yes! But it seems like the Canary jobs should align as well.

@dprince
Copy link
Contributor Author

dprince commented Aug 22, 2019

/test pj-rehearse

1 similar comment
@dprince
Copy link
Contributor Author

dprince commented Aug 22, 2019

/test pj-rehearse

@dprince dprince force-pushed the periodic_openstack branch from 6bf1a07 to 86f3035 Compare August 22, 2019 20:40
@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

@dprince dprince force-pushed the periodic_openstack branch from 86f3035 to 412a386 Compare August 23, 2019 12:01
@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

Just got word that the CI secrets for OpenStack jobs have been updated. They should now contain a registry key for "registry.connect.redhat.com", "registry.redhat.io", and "registry.svc.ci.openshift.org". So now maybe this has a chance to pass.

@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

4 similar comments
@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

@dprince
Copy link
Contributor Author

dprince commented Aug 23, 2019

/test pj-rehearse

@dprince
Copy link
Contributor Author

dprince commented Aug 24, 2019

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2019

@dprince: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/canary-openshift-ocp-installer-e2e-openstack-4.2 412a386 link /test pj-rehearse
ci/prow/pj-rehearse 412a386 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprince
Copy link
Contributor Author

dprince commented Aug 24, 2019

The OpenStack job is now running. As we've enabled all the tests there are some failures there but this job should be ready to land now I think.

@wking
Copy link
Member

wking commented Aug 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2019
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 24, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, eparis, iamemilio, stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 40d15a6 into openshift:master Aug 24, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2019

@dprince: Updated the job-config-misc configmap in namespace ci using the following files:

  • key openshift-release-release-4.2-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.2-periodics.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

3 more reviewers

@wking wking wking left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@eparis eparis

@iamemilio iamemilio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.