Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Aug 6, 2019

This adds a baremetal-installer image for use with baremetal IPI
platforms.

See: openshift/installer#2021

This adds a baremetal-installer image for use with baremetal IPI
platforms.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2019
@stbenjam
Copy link
Member Author

stbenjam commented Aug 6, 2019

/assign wking

@stbenjam
Copy link
Member Author

stbenjam commented Aug 6, 2019

Trying to move the conversation forward a bit on openshift/installer#2021. Sounds like we do need a baremetal-installer image as the alternatives aren't viable for 4.2. Do I need to include this in the 4.2 YAML as well?

I'm not sure what we would need to do to ensure the image gets included in a release image, @markmc's comment on the installer issue points to https://github.com/openshift/origin/blob/3e9167b8052283c6b15e215616090773532a0979/staging/src/github.com/openshift/oc/pkg/cli/admin/release/new.go#L50-L53, is that how we would do it?

@eparis
Copy link
Member

eparis commented Aug 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@wking
Copy link
Member

wking commented Aug 12, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, stbenjam, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit e3fd209 into openshift:master Aug 12, 2019
@openshift-ci-robot
Copy link
Contributor

@stbenjam: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
Details

In response to this:

This adds a baremetal-installer image for use with baremetal IPI
platforms.

See: openshift/installer#2021

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants