Skip to content

capo: Run verify and test in main and openshift modules #46134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 29, 2023
Merged

capo: Run verify and test in main and openshift modules #46134

openshift-merge-bot merged 1 commit into from
Nov 29, 2023

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Nov 28, 2023 •
edited
Loading

@mdbooth mdbooth force-pushed the capo-openshift-tests branch from 8e000fd to ac11b1f Compare November 28, 2023 14:54
@openshift-ci openshift-ci bot requested review from mandre and stephenfin November 28, 2023 15:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 28, 2023

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test-openshift
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test

@mdbooth mdbooth force-pushed the capo-openshift-tests branch from ac11b1f to fc6cb51 Compare November 28, 2023 15:35
@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 28, 2023

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test-openshift
/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 28, 2023

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test

mandre
mandre reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 28, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@mdbooth mdbooth force-pushed the capo-openshift-tests branch from fc6cb51 to cfd503d Compare November 29, 2023 10:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 29, 2023

[REHEARSALNOTIFIER]
@mdbooth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-api-provider-openstack-main-test-openshift openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-main-verify openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.15-test-openshift openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.15-verify openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.16-test-openshift openshift/cluster-api-provider-openstack presubmit Presubmit changed
pull-ci-openshift-cluster-api-provider-openstack-release-4.16-verify openshift/cluster-api-provider-openstack presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 29, 2023

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-api-provider-openstack/main/test fc6cb519d7ec9719dc0b58bda2f7bb09b0ef5d9d link unknown /pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 29, 2023

Note that this PR no longer modified test, which is presumably why pj-rehearse didn't run it. However, it seems that running it manually still fails. This presumably means this test failure is a separate issue unrelated to this PR.

/pj-rehearse pull-ci-openshift-cluster-api-provider-openstack-main-test

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 29, 2023

@mdbooth: job(s): pull-ci-openshift-cluster-api-provider-openstack-main-test either don't exist or were not found to be affected, and cannot be rehearsed

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 29, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 29, 2023
mandre
mandre reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 29, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7438459 into openshift:master Nov 29, 2023
@mdbooth mdbooth deleted the capo-openshift-tests branch November 29, 2023 15:36
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Nov 30, 2023
@mdbooth @Neha-dot-Yadav
capo: Run verify and test in main and openshift modules (openshift#46134
5e79a16 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenfin stephenfin Awaiting requested review from stephenfin

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdbooth @openshift-ci-robot @mandre