Skip to content

AGENT-725: Add presubmit job for vsphere #45475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwsu wants to merge 1 commit into from
Closed

AGENT-725: Add presubmit job for vsphere #45475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ci-operator/config/openshift/installer/openshift-installer-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,19 @@ tests:
INSTALLER_PROXY=true
workflow: agent-e2e-compact-ipv4
timeout: 6h0m0s
- always_run: false
as: e2e-agent-compact-ipv4-vmware
cluster: build05
optional: true
steps:
cluster_profile: equinix-ocp-metal
env:
DEVSCRIPTS_CONFIG: |
AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4
AGENT_PLATFORM_TYPE=vsphere
AGENT_WAIT_FOR_INSTALL_COMPLETE=false
workflow: agent-e2e-compact-ipv4
timeout: 6h0m0s
- as: e2e-agent-sno-ipv6
cluster: build05
optional: true
Expand Down
83 changes: 83 additions & 0 deletions ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2247,6 +2247,89 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-agent-compact-ipv4-none-platform,?($|\s.*)
- agent: kubernetes
always_run: false
branches:
- ^master$
- ^master-
cluster: build05
context: ci/prow/e2e-agent-compact-ipv4-vmware
decorate: true
decoration_config:
timeout: 6h0m0s
labels:
ci-operator.openshift.io/cloud: equinix-ocp-metal
ci-operator.openshift.io/cloud-cluster-profile: equinix-ocp-metal
ci-operator.openshift.io/cluster: build05
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-vmware
optional: true
rerun_command: /test e2e-agent-compact-ipv4-vmware
run_if_changed: /agent/

@zaneb zaneb Mar 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided to take this out, but once it is in the job is gets preserved even if you take it out of the config. (In the old days, you couldn't even put this stuff in the config, and many jobs still haven't so we have to continue preserving the data in the job because it's the only place it is recorded in many cases.) It pays to delete the job from this file and regenerate it to make sure it matches the config.

spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --secret-dir=/usr/local/e2e-agent-compact-ipv4-vmware-cluster-profile
- --target=e2e-agent-compact-ipv4-vmware
command:
- ci-operator
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /usr/local/e2e-agent-compact-ipv4-vmware-cluster-profile
name: cluster-profile
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: credentials
path: credentials
secretName: boskos-credentials
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: cluster-profile
secret:
secretName: cluster-secrets-equinix-ocp-metal
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-agent-compact-ipv4-vmware,?($|\s.*)
- agent: kubernetes
always_run: false
branches:
Expand Down