Skip to content

Installer: promote altinfra image#45169

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
patrickdillon:installer-promote-altinfra
Nov 6, 2023
Merged

Installer: promote altinfra image#45169
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
patrickdillon:installer-promote-altinfra

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Nov 1, 2023 •
edited
Loading

This alternate Installer image will be free of Terraform dependencies in order to mitigate any CVE issues.

Depends on openshift/installer#7656

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Nov 1, 2023

Was looking for guidance on how to add mappings and just discovered https://github.com/openshift/release/blob/388047f020e7dfff64ca3529c4bab9f50d4d2e19/core-services/image-mirroring/openshift/GUIDELINES.md so I will update this accordingly.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@bparees
Copy link
Contributor

bparees commented Nov 1, 2023

per conversation with @patrickdillon this image is temporary, so the name is fine.
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@patrickdillon patrickdillon mentioned this pull request Nov 2, 2023
Merged
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Nov 2, 2023

/hold

I dropped the Dockerfile from the installer repo so need to re-add the build tag here.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@patrickdillon patrickdillon force-pushed the installer-promote-altinfra branch from f00901f to 7b1963c Compare November 2, 2023 15:59
@patrickdillon
Copy link
Contributor Author

patrickdillon commented Nov 2, 2023

/hold cancel
Updates have been made to reintroduce the build tag.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@patrickdillon
Installer: promote altinfra image
9c8c6c3 
This alternatte Installer image will be free of Terraform dependencies
in order to mitigate any CVE issues.
@patrickdillon patrickdillon force-pushed the installer-promote-altinfra branch from 7b1963c to 9c8c6c3 Compare November 3, 2023 18:41
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023

[REHEARSALNOTIFIER]
@patrickdillon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-altinfra-images openshift/installer presubmit Presubmit changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-imdsv2 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc-localzones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn-resourcegroup openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-master-altinfra-e2e-azure-ovn-shared-vpc openshift/installer presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor

andfasano commented Nov 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bparees, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Nov 6, 2023

/pj rehearse-ack

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Nov 6, 2023

ug
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 8a9985a into openshift:master Nov 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

@patrickdillon: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_15 using file core-services/image-mirroring/openshift/mapping_origin_4_15
Details

In response to this:

This alternate Installer image will be free of Terraform dependencies in order to mitigate any CVE issues.

Depends on openshift/installer#7656

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@barbacbd barbacbd Awaiting requested review from barbacbd

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patrickdillon @bparees @openshift-ci-robot @andfasano

Comments