Skip to content

Conversation

@andfasano
Copy link
Contributor

In commit ceaa1d1 the openshift-bot erroneously replaced the origin installer image with the ocp ones for the OKD 4.15 variant jobs.
Since such image it's used to extract the rhcos (for ocp) or fcos/scos (for OKD) OS image and embed it within the machine-os-images image, this produced a wrong payload that was distributed in the CI streams and caused failures into other presubmit PR jobs depending on it.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-os-images-release-4.15-okd-images openshift/machine-os-images presubmit Ci-operator config changed
pull-ci-openshift-machine-os-images-release-4.15-okd-scos-images openshift/machine-os-images presubmit Ci-operator config changed
pull-ci-openshift-machine-os-images-main-okd-scos-images openshift/machine-os-images presubmit Ci-operator config changed
pull-ci-openshift-machine-os-images-main-okd-images openshift/machine-os-images presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor Author

/pj-rehearse

@openshift-ci openshift-ci bot requested review from elfosardo and jlebon October 31, 2023 16:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

/pj-rehearse ack

$  podman run --rm registry.build02.ci.openshift.org/ci-op-qvskw0z2/pipeline:machine-os-images cat coreos/coreos-stream.json | grep release
...
"release": "38.20231002.3.1"

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 31, 2023
@andfasano
Copy link
Contributor Author

/assign @sadasu

@sadasu
Copy link
Contributor

sadasu commented Oct 31, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@andfasano
Copy link
Contributor Author

cc @vrutkovs

@vrutkovs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, sadasu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants