Skip to content

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Jul 23, 2019

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2019
@hongkailiu hongkailiu force-pushed the fix branch 2 times, most recently from 0ddf191 to 152bae6 Compare July 23, 2019 21:27
@hongkailiu
Copy link
Member Author

Rehearsal looks good to me.

$ oc logs -n ci fbebb8e0-ad9d-11e9-8dfb-c85b76866133 -c test
doing region us-east-1 ...
handling cluster: kubernetes.io/cluster/ci-op-hp50v3hy-b88d6-j8qf5 ...
handling cluster: kubernetes.io/cluster/ci-op-724qy8fn-55c01-s5c8w ...
handling cluster: kubernetes.io/cluster/ci-op-nhr53mz6-55c01-thhgj ...
handling cluster: kubernetes.io/cluster/ci-op-hp50v3hy-d8d29-99p6q ...
doing region us-east-2 ...
doing region us-west-1 ...

@stevekuznetsov
Copy link
Contributor

OK, amazing -- can we factor out the configurable bits from the script into the job config as arguments to the script? I am thinking specifically right now for the "older than" check -- we will likely want to be changing that in production later.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2019
@hongkailiu hongkailiu force-pushed the fix branch 2 times, most recently from 20b5cea to b49ba64 Compare July 24, 2019 02:16
@petr-muller
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hongkailiu,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 00db3c0 into openshift:master Jul 24, 2019
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: Updated the job-config-misc configmap in namespace ci using the following files:

  • key infra-periodics.yaml using file ci-operator/jobs/infra-periodics.yaml
Details

In response to this:

https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants