-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix job periodic-ipi-deprovision #4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ddf191 to
152bae6
Compare
|
Rehearsal looks good to me. |
|
OK, amazing -- can we factor out the configurable bits from the script into the job config as arguments to the script? I am thinking specifically right now for the "older than" check -- we will likely want to be changing that in production later. |
20b5cea to
b49ba64
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hongkailiu: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html