Skip to content

OTA-740: ci-operator/step-registry/ipi/conf/telemetry: Disable by default (again) #44561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 1 commit into from
Closed

OTA-740: ci-operator/step-registry/ipi/conf/telemetry: Disable by default (again) #44561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ci-operator/step-registry/ipi/conf/telemetry/ipi-conf-telemetry-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@ set -o nounset
set -o errexit
set -o pipefail

if test -z "${TELEMETRY_ENABLED}"
then
if [[ "${JOB_NAME}" =~ 4[.]11 ]]
then
TELEMETRY_ENABLED=true
echo "TELEMETRY_ENABLED is empty, defaulting to '${TELEMETRY_ENABLED}' for the 4.11 ${JOB_NAME}"
else
TELEMETRY_ENABLED=false
echo "TELEMETRY_ENABLED is empty, defaulting to '${TELEMETRY_ENABLED}' for the not-4.11 ${JOB_NAME}"
fi
fi

if test true = "${TELEMETRY_ENABLED}"
then
echo "Nothing to do with TELEMETRY_ENABLED='${TELEMETRY_ENABLED}'"
Expand Down
6 changes: 3 additions & 3 deletions ci-operator/step-registry/ipi/conf/telemetry/ipi-conf-telemetry-ref.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ ref:
memory: 100Mi
env:
- name: TELEMETRY_ENABLED
default: "true"
default: ""
documentation: |-
Enable Telemetry:
* "false" - do not enable Telemetry
* "true" (default) - enable Telemetry
* "false" (default for most jobs) - do not enable Telemetry
* "true" (default when JOB_NAME includes 4.11) - enable Telemetry
documentation: |-
The configure telemetry step generates a "${SHARED_DIR}/manifest_cluster-monitoring-config.yaml" manifest, or manipulates the manifest if it already exists, to configure telemeterClient's enabled property.