Skip to content

Add periodic-ipi-deprovision job #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 23, 2019
Merged

Add periodic-ipi-deprovision job #4452

openshift-merge-robot merged 1 commit into from
Jul 23, 2019

Conversation

@hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Jul 19, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2019
petr-muller
petr-muller reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual deprovisioner, even if it is a simple shell script, should live in the ci-tools repository and be built by ci-operator - then you would not need an ImageStream here, just the periodic job.

I also don't think we should add new config to legacy places, IMO this belongs to somewhere to core-services where it is covered by auto-apply and dry-run presubmit automatically. I think this could either go to core-services/supplemental-ci-images, or to a new core-services/ipi-deprovisioner location (depending how big/significant this thing is), following the instructions.

projects/origin-release/ipi_deprovision/Dockerfile Outdated
Copy link
Member

@petr-muller petr-muller Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be somewhere under core-services, or even better, in the ci-tools repo.

Copy link
Member Author

@hongkailiu hongkailiu Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/ci-tools#26

projects/origin-release/ipi_deprovision/ipi-deprovision.yaml Outdated
Copy link
Member

@petr-muller petr-muller Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be somewhere under core-services, or even not needed if we build the image with ci-operator.

Copy link
Member Author

@hongkailiu hongkailiu Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/ci-tools#26

projects/origin-release/ipi_deprovision/run.sh Outdated
Copy link
Member

@petr-muller petr-muller Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be somewhere under core-services, or even better, in ci-tools repo.

Copy link
Member Author

@hongkailiu hongkailiu Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/ci-tools#26

hongkailiu
hongkailiu commented Jul 22, 2019
View reviewed changes
ci-operator/config/openshift/ci-tools/openshift-ci-tools-master.yaml Outdated
Copy link
Member Author

@hongkailiu hongkailiu Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be updated.

@hongkailiu hongkailiu force-pushed the DPTP-471 branch 3 times, most recently from d17a5de to 4211877 Compare July 22, 2019 14:58
petr-muller
petr-muller reviewed Jul 22, 2019
View reviewed changes
@hongkailiu hongkailiu changed the title Build image ipi-deprovision Add periodic-ipi-deprovision job Jul 22, 2019
@petr-muller
Copy link
Member

petr-muller commented Jul 23, 2019

/retest

petr-muller
petr-muller approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hongkailiu,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 15612fc into openshift:master Jul 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2019

@hongkailiu: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-ci-tools-master.yaml using file ci-operator/config/openshift/ci-tools/openshift-ci-tools-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-ci-tools-master.yaml using file ci-operator/config/openshift/ci-tools/openshift-ci-tools-master.yaml
  • job-config-misc configmap in namespace ci using the following files:
    • key infra-periodics.yaml using file ci-operator/jobs/infra-periodics.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hongkailiu @petr-muller @openshift-ci-robot @openshift-merge-robot