platform-operators: intermediate bump to go 1.19 to unwedge CI #44359
Conversation
…operator CI jobs Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
|
/pj-rehearse auto-ack |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
bot
added
the
approved
| image_stream_tag: | ||
| name: release | ||
| namespace: openshift | ||
| tag: golang-1.18 |
There was a problem hiding this comment.
Can you use this instead?
build_root:
from_repository: true
There was a problem hiding this comment.
Presumably, this will keep up with the value in go.mod, and thus, never need to be modified again?
There was a problem hiding this comment.
There was a problem hiding this comment.
From whatever branch is appropriate
There was a problem hiding this comment.
Better than having to modify this repo...
There was a problem hiding this comment.
I can't. Go 1.20 from the repo fails CI. And 1.18 also fails CI.
I have another PR open to switch to from_repository.
There was a problem hiding this comment.
Might need more surgery though. Maybe need to temporarily disable the lint test. Or force a go bump.
There was a problem hiding this comment.
I figured out at least one problem. platform-operators tries to use setup-envtest@latest, which apparently now requires a more recent version of Go to work.
I've updated @awgreene's PR (openshift/platform-operators#92) to pin setup-envtest. And I've also opened a separate PR to switch CI tooling over to bingo (openshift/platform-operators#95) to make sure build tools actually stay pinned.
We may still need this PR because there is also an interplay between golangci-lint and the go compiler version that may require an intermediate bump to Go 1.19.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
What's going on with the rehearsal failures? |
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
4 participants
No description provided.