-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add CAPO verify tests #43982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CAPO verify tests #43982
Conversation
|
We expect verify to fail until we merge:
I'll run it anyway just to confirm it runs the make target before failing. /pj-rehearse |
|
Failed because golangci-lint is trying to write to /.cache, which is unexpected. Added an explicit cache directory and trying again until it fails for the expected reasons. /pj-rehearse |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
This is now failing because vendoring is broken on the main branch, which is expected. /pj-rehearse skip |
|
/assign @mandre |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
As pointed out by @EmilienM the test and verify jobs are required, which is preventing us from merging anything in CAPO. Making this new test pass requires merging and backporting an additional upstream PR. Therefore we MUST NOT merge this until we have merged: and backported and merged: |
|
@mdbooth: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TODO before merging: