Skip to content

image-mirroring: Drop driver-toolkit from OKD 4.{13,14} #43957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Oct 24, 2023
Merged

image-mirroring: Drop driver-toolkit from OKD 4.{13,14} #43957

openshift-ci merged 1 commit into from
Oct 24, 2023

Conversation

@LorbusChris
Copy link
Contributor

@LorbusChris LorbusChris commented Oct 4, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 4, 2023
@LorbusChris LorbusChris mentioned this pull request Oct 4, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2023

[REHEARSALNOTIFIER]
@LorbusChris: no rehearsable tests are affected by this change

@openshift-ci openshift-ci bot requested review from stbenjam and xueqzhan October 4, 2023 12:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

@LorbusChris: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ybettan
ybettan reviewed Oct 4, 2023
View reviewed changes
core-services/image-mirroring/openshift/mapping_origin_4_14
registry.ci.openshift.org/origin/4.14:docker-builder quay.io/openshift/origin-docker-builder:4.14 quay.io/openshift/origin-docker-builder:4.14.0
registry.ci.openshift.org/origin/4.14:docker-registry quay.io/openshift/origin-docker-registry:4.14 quay.io/openshift/origin-docker-registry:4.14.0
registry.ci.openshift.org/origin/4.14:dpu-network-operator quay.io/openshift/origin-dpu-network-operator:4.14 quay.io/openshift/origin-dpu-network-operator:4.14.0
registry.ci.openshift.org/origin/4.14:driver-toolkit quay.io/openshift/origin-driver-toolkit:4.14 quay.io/openshift/origin-driver-toolkit:4.14.0
Copy link
Member

@ybettan ybettan Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we care about older versions? Can't we just keep machine-os-content for older version of OCP and only remove it in newer versions?

Copy link
Contributor Author

@LorbusChris LorbusChris Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machine-os-content is not touched here. This change removes an OCP CI image that has been leaking into OKD releases (driver-toolkit).

@ybettan
Copy link
Member

ybettan commented Oct 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2023
@LorbusChris
Copy link
Contributor Author

LorbusChris commented Oct 24, 2023

/assign @jupierce

@jupierce
Copy link
Contributor

jupierce commented Oct 24, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, LorbusChris, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@openshift-ci openshift-ci bot merged commit 946b646 into openshift:master Oct 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@LorbusChris: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_13 using file core-services/image-mirroring/openshift/mapping_origin_4_13
  • key mapping_origin_4_14 using file core-services/image-mirroring/openshift/mapping_origin_4_14
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

1 more reviewer

@ybettan ybettan ybettan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jupierce jupierce

@ybettan ybettan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LorbusChris @openshift-ci-robot @ybettan @jupierce