Skip to content

Add intaller e2e tests for oVirt platform #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Jan 14, 2020
Merged

Add intaller e2e tests for oVirt platform #4340

openshift-merge-robot merged 5 commits into from
Jan 14, 2020

Conversation

@rgolangh
Copy link
Contributor

@rgolangh rgolangh commented Jul 11, 2019 •
edited
Loading

This PR will allow running e2e of openshift/installer for ovirt.
oVirt platform installer patch is still in review - openshift/installer#1948

Related: github.com/openshift/installer/pull/1948
Enhancement: openshift/enhancements#61

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 11, 2019

Hi @rgolangh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 11, 2019
stevekuznetsov
stevekuznetsov reviewed Jul 11, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2019
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Aug 21, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2019
@rgolangh rgolangh mentioned this pull request Oct 7, 2019
Merged
stevekuznetsov
stevekuznetsov reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be a separate template? @wking

@wking
Copy link
Member

wking commented Oct 8, 2019

Why does this need to be a separate template?

Do we? I'd much prefer conditionals in existing templates.

@rgolangh rgolangh force-pushed the master branch 2 times, most recently from 1cc9d67 to 4034bef Compare October 22, 2019 15:43
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Oct 23, 2019

/test pj-rehearse

1 similar comment
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented Oct 23, 2019

/test pj-rehearse

stevekuznetsov
stevekuznetsov reviewed Oct 23, 2019
View reviewed changes
@rgolangh rgolangh force-pushed the master branch 3 times, most recently from 897407d to 122210a Compare October 24, 2019 13:37
@Gal-Zaidman
Copy link
Contributor

Gal-Zaidman commented Jan 9, 2020

/test pj-rehearse

@Gal-Zaidman Gal-Zaidman force-pushed the master branch 3 times, most recently from 92523fd to e92a63d Compare January 9, 2020 12:00
@Gal-Zaidman
Copy link
Contributor

Gal-Zaidman commented Jan 9, 2020

/test pj-rehearse

3 similar comments
@Gal-Zaidman
Copy link
Contributor

Gal-Zaidman commented Jan 12, 2020

/test pj-rehearse

@Gal-Zaidman
Copy link
Contributor

Gal-Zaidman commented Jan 12, 2020

/test pj-rehearse

@Gal-Zaidman
Copy link
Contributor

Gal-Zaidman commented Jan 12, 2020

/test pj-rehearse

@Gal-Zaidman Gal-Zaidman force-pushed the master branch 2 times, most recently from 71184c1 to bcbb27a Compare January 13, 2020 06:12
Gal Zaidman added 4 commits January 14, 2020 10:22
Add ci operator ovirt configuration
3d99290 
Thist patch adds ovirt to the ci-operator
openshift installer configuration

Signed-off-by: Gal Zaidman <[email protected]>
Add ovirt e2e template
36c8c51 
This patch adds ovirt e2e template,
the template runs lease,setup,test,teardown containers

Signed-off-by: Gal Zaidman <[email protected]>
Add presubmits and periodics-4.4 jobs
898be6a 
Signed-off-by: Gal Zaidman <[email protected]>
Add ovirt to release
dd5a4c4 
Signed-off-by: Gal Zaidman <[email protected]>
@Gal-Zaidman Gal-Zaidman force-pushed the master branch 2 times, most recently from 00ca32b to b0db315 Compare January 14, 2020 10:55
@petr-muller
Copy link
Member

petr-muller commented Jan 14, 2020

/test all

Lease handling for conformance tests suite
5c79bfa 
To better utilize our resources we determined that
run-minimal test will create a cluster with half
the resources needed for conformance.
This patch introduces the logic for acquiring 2 leases
for conformance and one for minimal suite.
Notice that at the moment since we have separate ovirt clusters
we needed to make sure that the first and second lease will use
the same ovirt cluster.

Signed-off-by: Gal Zaidman <[email protected]>
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8492094 into openshift:master Jan 14, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2020

@rgolangh: Updated the following 8 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • prow-job-cluster-launch-installer-ovirt-e2e configmap in namespace ci-stg at cluster default using the following files:
    • key cluster-launch-installer-ovirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-ovirt-e2e.yaml
  • job-config-master configmap in namespace ci at cluster default using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster default using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-4.4 configmap in namespace ci at cluster default using the following files:
    • key openshift-release-release-4.4-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml
  • prow-job-cluster-launch-installer-ovirt-e2e configmap in namespace ci at cluster default using the following files:
    • key cluster-launch-installer-ovirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-ovirt-e2e.yaml
  • releases configmap in namespace ocp at cluster default using the following files:
    • key release-ocp-4.4.json using file core-services/release-controller/_releases/release-ocp-4.4.json
Details

In response to this:

This PR will allow running e2e of openshift/installer for ovirt.
oVirt platform installer patch is still in review - openshift/installer#1948

Related: github.com/openshift/installer/pull/1948
Enhancement: openshift/enhancements#61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2020

@rgolangh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-restore-cluster-state 3ecf089 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-etcd-quorum-loss 3ecf089 link /test pj-rehearse
ci/rehearse/release-openshift-ocp-installer-e2e-ovirt-4.3 3a608132cb8670c0ce9e27ea0655ddfa01cdde08 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e 1a0f3972ebce49925bedba558c494c4d31e10189 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upgrade 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-fips 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-parallel 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-shared-vpc 5c79bfa link /test pj-rehearse
ci/rehearse/release-openshift-ocp-installer-e2e-ovirt-4.4 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-upi 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-disruptive 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azure-shared-vpc 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-azure 5c79bfa link /test pj-rehearse
ci/prow/pj-rehearse 5c79bfa link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-scaleup-rhel7 5c79bfa link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking wking mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@russellb russellb Awaiting requested review from russellb

2 more reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

@petr-muller petr-muller

@jcpowermac jcpowermac

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.