Skip to content

aws-console-ref: use latest upi-installer #43322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 14, 2023
Merged

aws-console-ref: use latest upi-installer #43322

openshift-merge-robot merged 1 commit into from
Sep 14, 2023

Conversation

@rphillips
Copy link
Contributor

@rphillips rphillips commented Sep 13, 2023 •
edited
Loading

Fixes getting console logs by setting C.utf8 as the locale.

@openshift-ci openshift-ci bot requested review from dgoodwin and stbenjam September 13, 2023 16:13
@rphillips
Copy link
Contributor Author

rphillips commented Sep 13, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

1 similar comment
@rphillips
Copy link
Contributor Author

rphillips commented Sep 13, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

@rphillips
Copy link
Contributor Author

rphillips commented Sep 13, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 14, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 14, 2023
@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive
/pj-rehearse periodic-ci-openshift-release-master-ci-4.11-e2e-aws

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive
/pj-rehearse periodic-ci-openshift-release-master-ci-4.11-e2e-aws

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.11-e2e-aws-disruptive

@rphillips
aws-console-ref: use latest upi-installer
d96565f 
Back in openshift#9791 we pinned 4.5 because it had aws , while 4.4 did not. We no longer need this step to be compatible with 4.4 or earlier installs.  We do need to be compatible with 4.14, which no longer has en_US.utf8.  And we need to work with 4.11, which does not have C.utf8.  So pin 4.14, so we can rely on a UPI-installer image that's compatible with this script, so we can get clusters for all 4.11 and later releases.  Don't worry that we won't be excercising 4.11, etc. upi-images, they don't change much.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2023

[REHEARSALNOTIFIER]
@rphillips: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-modelmesh-runtime-adapter-main-fvt opendatahub-io/modelmesh-runtime-adapter presubmit Registry content changed
pull-ci-opendatahub-io-modelmesh-runtime-adapter-release-v0.11.0-alpha-fvt opendatahub-io/modelmesh-runtime-adapter presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.4-e2e-aws-ocp-44 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.4-upgrade-tests-aws-ocp-44 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.5-4.3-e2e-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.5-4.3-upgrade-tests-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.5-4.4-e2e-aws-ocp-44 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.5-e2e-aws-ocp-45 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.5-upgrade-tests-aws-ocp-45 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.4-4.2-e2e-aws-ocp-42 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.4-4.2-upgrade-tests-aws-ocp-42 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.7-4.4-e2e-aws-ocp-44 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.7-4.4-upgrade-tests-aws-ocp-44 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.3-e2e-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.6-4.3-upgrade-tests-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.4-4.3-e2e-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.4-4.3-upgrade-tests-aws-ocp-43 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.16-4.8-operator-e2e-aws-ocp-48 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.16-4.8-upstream-e2e-aws-ocp-48 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.16-4.8-upgrade-tests-aws-ocp-48 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.13-4.7-operator-e2e-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.13-4.7-upstream-e2e-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.13-4.7-upgrade-tests-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.14-4.7-operator-e2e-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.14-4.7-upstream-e2e-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.14-4.7-upgrade-tests-aws-ocp-47 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.9-4.5-operator-e2e-aws-ocp-45 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.9-4.5-upstream-e2e-aws-ocp-45 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.9-4.5-upgrade-tests-aws-ocp-45 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.19-4.6-operator-e2e-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.19-4.6-upstream-e2e-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.19-4.6-upgrade-tests-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.20-4.6-operator-e2e-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.20-4.6-upstream-e2e-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed
pull-ci-openshift-knative-serverless-operator-release-1.20-4.6-upgrade-tests-aws-ocp-46 openshift-knative/serverless-operator presubmit Registry content changed

A total of 6832 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.11/e2e-aws-disruptive d7cdee8e34edb42b79aca7c6175f83e06013a6d0 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.11-e2e-aws-disruptive
ci/rehearse/openshift/machine-config-operator/release-4.14/e2e-aws-disruptive d7cdee8e34edb42b79aca7c6175f83e06013a6d0 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.11-e2e-aws-disruptive
/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 14, 2023

@rphillips, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 9edcc4a89c70b8dafc64649243f0dd4824f6528b]' failed with out: fatal: reference is not a tree: 9edcc4a89c70b8dafc64649243f0dd4824f6528b
and error exit status 128

If the problem persists, please contact Test Platform.

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.11-e2e-aws-disruptive
/pj-rehearse pull-ci-openshift-machine-config-operator-release-4.14-e2e-aws-disruptive

@rphillips
Copy link
Contributor Author

rphillips commented Sep 14, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 14, 2023
wking
wking approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 68d8a20 into openshift:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@stbenjam stbenjam Awaiting requested review from stbenjam

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rphillips @openshift-ci-robot @wking @openshift-merge-robot