Skip to content

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Jul 2, 2019

A companion PR to openshift/ci-tools#13

@openshift/sig-azure looks good to you? I guess removing the empty-ish files is fine. How about the branch-ci-openshift-openshift-azure-openshift-v4-images job? It used to be generated by Prowgen, but it would not be generated now, so it should either be removed (this PR), or its ci-operator.openshift.io/prowgen-controlled label should be removed (then prowgen won't prune it).

@openshift-ci-robot openshift-ci-robot added the sig/azure Categorizes item related to Azure jobs label Jul 2, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2019
@mjudeikis
Copy link
Contributor

/lgtm
Thanks @petr-muller !!!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 81736c6 into openshift:master Jul 2, 2019
Copy link
Contributor

@charlesakalugwu charlesakalugwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/azure Categorizes item related to Azure jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants