-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ipi-install: avoid failing step on OSUS config corner cases #42231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipi-install: avoid failing step on OSUS config corner cases #42231
Conversation
|
/pj-rehearse periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-s390x pull-ci-openshift-coredns-master-e2e-aws-ovn pull-ci-maistra-envoy-maistra-2.4-maistra-envoy-unit-2-4 |
|
/cc @vrutkovs |
|
@petr-muller: job(s): periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade either don't exist or were not found to be affected, and cannot be rehearsed |
5e698f8 to
239f494
Compare
right, cannot rehearse upgrade jobs b/c I'm technically not touching stableinitial. but i should not need it anyway /pj-rehearse periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-s390x pull-ci-openshift-coredns-master-e2e-aws-ovn pull-ci-maistra-envoy-maistra-2.4-maistra-envoy-unit-2-4 |
|
[REHEARSALNOTIFIER]
A total of 11235 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
vrutkovs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
|
Behavior with OKD is like expected: |
|
@petr-muller: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
#40711 broke OKD jobs like https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn/1689787699755487232
We should only mess up with OSUS if we work with OCP channels. bail out when we do not find a well-known channel in the CVO overrides file.
I also added a check for the presence of CVO overrides file itself, for good measure