Skip to content

Conversation

@petr-muller
Copy link
Member

#40711 broke OKD jobs like https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn/1689787699755487232

We should only mess up with OSUS if we work with OCP channels. bail out when we do not find a well-known channel in the CVO overrides file.

I also added a check for the presence of CVO overrides file itself, for good measure

@openshift-ci openshift-ci bot requested review from deepsm007 and stbenjam August 11, 2023 09:53
@petr-muller
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-s390x pull-ci-openshift-coredns-master-e2e-aws-ovn pull-ci-maistra-envoy-maistra-2.4-maistra-envoy-unit-2-4

@petr-muller
Copy link
Member Author

/cc @vrutkovs

@openshift-ci openshift-ci bot requested a review from vrutkovs August 11, 2023 09:54
@openshift-ci-robot
Copy link
Contributor

@petr-muller: job(s): periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade either don't exist or were not found to be affected, and cannot be rehearsed

@petr-muller petr-muller force-pushed the ota-905-fixup-okd-installation branch from 5e698f8 to 239f494 Compare August 11, 2023 09:58
@petr-muller
Copy link
Member Author

job(s): periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade either don't exist or were not found to be affected, and cannot be rehearsed

right, cannot rehearse upgrade jobs b/c I'm technically not touching stableinitial. but i should not need it anyway

/pj-rehearse periodic-ci-openshift-release-master-okd-4.14-e2e-aws-ovn periodic-ci-openshift-multiarch-master-nightly-4.14-ocp-e2e-ibmcloud-ovn-multi-s390x pull-ci-openshift-coredns-master-e2e-aws-ovn pull-ci-maistra-envoy-maistra-2.4-maistra-envoy-unit-2-4

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-metrics-collector-release-2.3-e2e stolostron/metrics-collector presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-main-ci-install-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-main-ci-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.13-ci-install-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.13-ci-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.12-ci-install-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.12-ci-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.11-ci-install-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.11-ci-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.10-ci-install-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-kni-numaresources-operator-release-4.10-ci-e2e openshift-kni/numaresources-operator presubmit Registry content changed
pull-ci-openshift-oc-compliance-master-e2e openshift/oc-compliance presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-master-e2e-aws-ovn openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.15-e2e-aws-ovn openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.14-e2e-aws-ovn openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.13-e2e-aws-ovn openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.12-e2e-aws-ovn openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.11-e2e-aws openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.10-e2e-aws openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.9-e2e-aws openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.8-e2e-aws openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.13-e2e-aws-ovn-ccm openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.12-e2e-aws-ovn-ccm openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.11-e2e-aws-ccm openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.10-e2e-aws-ccm openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.13-e2e-aws-ovn-ccm-install openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.12-e2e-aws-ovn-ccm-install openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.11-e2e-aws-ccm-install openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.10-e2e-aws-ccm-install openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-master-e2e-aws-ovn-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.15-e2e-aws-ovn-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.14-e2e-aws-ovn-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.13-e2e-aws-ovn-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.12-e2e-aws-ovn-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed
pull-ci-openshift-cloud-provider-aws-release-4.11-e2e-aws-cgroupsv2 openshift/cloud-provider-aws presubmit Registry content changed

A total of 11235 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@vrutkovs
Copy link
Contributor

INFO[2023-08-11T10:06:07Z] Running step e2e-aws-ovn-ipi-install-install. 
INFO[2023-08-11T10:36:51Z] Step e2e-aws-ovn-ipi-install-install succeeded after 30m43s. 

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 11, 2023
@petr-muller
Copy link
Member Author

Behavior with OKD is like expected:

Release payload version: 4.14.0-0.okd-2023-08-10-204608
Payload architecture not found in .metadata.metadata["release.openshift.io/architecture"], using .config.architecture
Release payload architecture: amd64
No known OCP channel found in CVO manifest, clearing the channel
Will include manifests:

@openshift-merge-robot openshift-merge-robot merged commit 2af156e into openshift:master Aug 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

@petr-muller: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/coredns/master/e2e-aws-ovn 239f494 link unknown /pj-rehearse pull-ci-openshift-coredns-master-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants