Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 10, 2023

Rolling back changes from 26ebda9 (#40924) and similar, CC @jmguzik. credentials-request-freeze jobs are very cheap, because they do not launch a cluster (they just compare release image content), and running them more frequently gives plenty of post-merge time before a release gets cut to discuss what to do about changes like openshift/cluster-ingress-operator#954 adding route53:ListTagsForResources as an ingress permission in 4.12.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-ci openshift-ci bot requested review from neisw and vrutkovs August 10, 2023 21:19
…every 48h

Rolling back changes from 26ebda9 (Bulk frequency reduce of 4.12
periodics to limit costs of CI platform, 2023-07-07, openshift#40924) and
similar.  These jobs are very cheap, because they do not launch a
cluster (they just compare release image content), and running them
more frequently gives plenty of post-merge time before a release gets
cut to discuss what to do about changes like [1] adding
route53:ListTagsForResources as an ingress permission in 4.12.

[1]: openshift/cluster-ingress-operator#954
@wking wking force-pushed the frequent-cred-freeze-runs branch from e1b4403 to d2d6640 Compare August 13, 2023 14:40
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@wking: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.12-credentials-request-freeze N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.9-credentials-request-freeze N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.7-credentials-request-freeze N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.10-credentials-request-freeze N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.8-credentials-request-freeze N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@wking
Copy link
Member Author

wking commented Aug 14, 2023

Nothing to rehearse; I'm just adjusting the interval.

/pj-rehearse ack

@patrickdillon
Copy link
Contributor

/lgtm

@patrickdillon
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 15, 2023
@patrickdillon
Copy link
Contributor

/lgtm

@patrickdillon
Copy link
Contributor

prow likes rehearsal ack but not lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 37b5334 into openshift:master Aug 15, 2023
@wking wking deleted the frequent-cred-freeze-runs branch August 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants