Skip to content

Adding AWS Local Zone Phase 2 CI #41574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 31, 2023
Merged

Adding AWS Local Zone Phase 2 CI #41574

openshift-merge-robot merged 1 commit into from
Jul 31, 2023

Conversation

@yunjiang29
Copy link
Contributor

@yunjiang29 yunjiang29 commented Jul 24, 2023 •
edited
Loading

Changes

  • Rename existing cucushift-installer-rehearse-aws-ipi-localzone[-sdn] to cucushift-installer-rehearse-aws-ipi-localzone-byo-subnet[-sdn], the byo-subnet workflow is for Phase 1 (4.13 and above), the VPC and Local Zone subnets are pre-created
  • The new workflow cucushift-installer-rehearse-aws-ipi-localzone[-sdn] is for Phase 2 (4.14 and above), VPC and Local Zone subnets are created by installer

Installer PR openshift/installer#7137
Enhancement PR openshift/enhancements#1232

Phase 2: installer can create localzone subnet automatically (platform.aws.subnets is not required). e.g:

apiVersion: v1
baseDomain: example.com
metadata:
  name: edge-cluster
compute:
- name: edge
  platform:
    aws:
      zones:
      - us-east-1-nyc-1a

workflows

4.13

- as: aws-ipi-disconnected-mtu-localzone-fips-p2-f14
- as: aws-ipi-disconnected-mtu-localzone-fips-p3-f28-destructive
- as: aws-ipi-localzone-byo-subnet-p2-f14
- as: aws-ipi-localzone-byo-subnet-p3-f28-destructive
- as: aws-ipi-localzone-byo-subnet-sdn-p2-f14
- as: aws-ipi-localzone-byo-subnet-sdn-p3-f28-destructive

4.14

- as: aws-ipi-disconnected-mtu-localzone-fips-f14
- as: aws-ipi-disconnected-mtu-localzone-fips-f28-destructive
- as: aws-ipi-localzone-byo-subnet-sdn-f14
- as: aws-ipi-localzone-byo-subnet-sdn-f28-destructive
- as: aws-ipi-localzone-fips-f14
- as: aws-ipi-localzone-fips-f28-destructive

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 24, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@openshift-ci openshift-ci bot requested review from deepsm007 and gpei July 24, 2023 07:20
@yunjiang29 yunjiang29 changed the title AWS Local Zone Phase 2 Adding AWS Local Zone Phase 2 CI Jul 24, 2023
@yunjiang29 yunjiang29 force-pushed the lz-phase2 branch 2 times, most recently from 2f8e4be to d45fe1b Compare July 27, 2023 09:39
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 27, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 27, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2023

@yunjiang29, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: Workflow cucushift-installer-rehearse-aws-ipi-network-mtu-localzone contains non-existent chain cucushift-installer-rehearse-aws-ipi-localzone-deprovision
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yunjiang29 yunjiang29 force-pushed the lz-phase2 branch 2 times, most recently from 2091af3 to f1a5c2b Compare July 28, 2023 04:47
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2023

[REHEARSALNOTIFIER]
@yunjiang29: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-aws-ipi-disconnected-private-tp-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-aws-ipi-disconnected-private-sno-baselinecaps-none-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-aws-ipi-disconnected-sts-ep-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.11-installer-rehearse-aws-sc2s N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-aws-ipi-disconnected-sts-ep-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-private-sno-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-devpreview-aws-sc2s-ipi-disconnected-private-fips-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-aws-c2s-ipi-disconnected-private-fips-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-4.11-upgrade-from-stable-4.10-aws-ipi-disconnected-sts-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-private-sno-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-stable-4.9-aws-c2s-ipi-disconnected-private-fips-cert-rotation-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.13-aws-ipi-disconnected-sts-ep-p2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-aws-ipi-disconnected-private-tp-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-devpreview-4.14-aws-ipi-disconnected-mtu-localzone-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-disconnected-sts-p2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-disconnect-sdn-worker-rhcos-rhel8-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-devpreview-4.14-aws-ipi-disconnected-sts-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-aws-c2s-ipi-disconnected-private-fips-cert-rotation-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-sts-ep-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-disconnected-private-sno-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-aws-ipi-disconnected-private-sno-baseline-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-private-tp-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-sts-ep-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-disconnected-mtu-localzone-fips-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-devpreview-aws-ipi-disconnected-private-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-aws-ipi-disconnected-private-sno-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-aws-ipi-disconnected-private-sno-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-arm64-nightly-4.11-upgrade-from-stable-4.10-aws-ipi-disconnected-sts-ep-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-devpreview-aws-ipi-disconnected-sts-efs-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-aws-ipi-disconnected-sts-ep-fips-f28-destructive N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-omr-ocp414-quay-omr-tests-omr-ocp414-disconnected N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-private-p1-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-workers-rhcos-rhel8-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-aws-ipi-disconnected-sts-efs-f14 N/A periodic Registry content changed

A total of 324 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

@jianlinliu @gpei Please review this PR when you are available, thanks

@jianlinliu
Copy link
Contributor

jianlinliu commented Jul 28, 2023 

- as: aws-ipi-localzone-byo-subnet-sdn-f14
- as: aws-ipi-localzone-byo-subnet-sdn-f28-destructive
- as: aws-ipi-localzone-fips-f14
- as: aws-ipi-localzone-fips-f28-destructive

So for sdn, even 4.14 comes to phase 2, still need byo subnet?

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

So for sdn, even 4.14 comes to phase 2, still need byo subnet?

No, just to make sure byo-subnet and sdn are covered in 4.14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

Test

4.14 without byo-vpc

https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/41574/rehearse-41574-periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14/1684806121312751616

controlPlane:
  platform:
    aws:
      zones:
      - us-east-1f
      - us-east-1a
      type: m6i.xlarge
  architecture: amd64
  name: master
compute:
- platform:
    aws:
      zones:
      - us-east-1f
      - us-east-1a
      type: m5.xlarge
  architecture: amd64
  name: worker
  replicas: 3
- name: edge
  architecture: amd64
  hyperthreading: Enabled
  replicas: 1
  platform:
    aws:
      type: c5d.2xlarge
      zones: [us-east-1-msp-1a]
baseDomain: qe.devcluster.openshift.com
platform:
  aws:
    region: us-east-1
    userTags:
      expirationDate: 2023-07-28T14:04+0000

4.13 with byo-vpc

https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/41574/rehearse-41574-periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14/1684805962076000256

platform:
  aws:
    subnets:
    - 'subnet-0561c4f3092c8f629'
    - 'subnet-096a538e3b95eb2eb'
    - 'subnet-0731d3e94870cb715'
    - 'subnet-0889c6f09790b8044'
    - 'subnet-0842842c0f717556f'
    - 'subnet-0afd97710d068cdda'
    - subnet-054eab52ff9b6f80e
    region: us-east-1
    userTags:
      expirationDate: 2023-07-28T14:07+0000
controlPlane:
  platform:
    aws:
      zones:
      - "us-east-1a"
      - "us-east-1b"
      - "us-east-1c"
      type: m6i.xlarge
  architecture: amd64
  name: master
compute:
- platform:
    aws:
      zones:
      - "us-east-1a"
      - "us-east-1b"
      - "us-east-1c"
      type: m5.xlarge
  architecture: amd64
  name: worker
  replicas: 3
- name: edge
  architecture: amd64
  hyperthreading: Enabled
  replicas: 1
  platform:
    aws:
      type: c5d.2xlarge
      zones: [us-east-1-iah-1a]
baseDomain: qe.devcluster.openshift.com

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2023
@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Jul 28, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 28, 2023
@jianlinliu
Copy link
Contributor

jianlinliu commented Jul 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@jianlinliu
Copy link
Contributor

jianlinliu commented Jul 28, 2023

cc @liangxia to review

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2023

@yunjiang29: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-f14 0424030be8201fb3a00406bce088fe2edcaed67f link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14 5ffd144 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-localzone-byo-subnet-p2-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14 5ffd144 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-aws-ipi-localzone-fips-f14

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liangxia
Copy link
Member

liangxia commented Jul 31, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianlinliu, liangxia, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit c9ebca7 into openshift:master Jul 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@yunjiang29: Updated the following 4 configmaps:

  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.13-periodics.yaml using file ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13-periodics.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.14-periodics.yaml using file ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14-periodics.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.13__amd64-nightly-4.13-upgrade-from-stable-4.13.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13__amd64-nightly-4.13-upgrade-from-stable-4.13.yaml
    • key openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.14__amd64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__amd64-nightly.yaml
Details

In response to this:

Changes

  • Rename existing cucushift-installer-rehearse-aws-ipi-localzone[-sdn] to cucushift-installer-rehearse-aws-ipi-localzone-byo-subnet[-sdn], the byo-subnet workflow is for Phase 1 (4.13 and above), the VPC and Local Zone subnets are pre-created
  • The new workflow cucushift-installer-rehearse-aws-ipi-localzone[-sdn] is for Phase 2 (4.14 and above), VPC and Local Zone subnets are created by installer

Installer PR openshift/installer#7137
Enhancement PR openshift/enhancements#1232

Phase 2: installer can create localzone subnet automatically (platform.aws.subnets is not required). e.g:

apiVersion: v1
baseDomain: example.com
metadata:
 name: edge-cluster
compute:
- name: edge
 platform:
   aws:
     zones:
     - us-east-1-nyc-1a

workflows

4.13

- as: aws-ipi-disconnected-mtu-localzone-fips-p2-f14
- as: aws-ipi-disconnected-mtu-localzone-fips-p3-f28-destructive
- as: aws-ipi-localzone-byo-subnet-p2-f14
- as: aws-ipi-localzone-byo-subnet-p3-f28-destructive
- as: aws-ipi-localzone-byo-subnet-sdn-p2-f14
- as: aws-ipi-localzone-byo-subnet-sdn-p3-f28-destructive

4.14

- as: aws-ipi-disconnected-mtu-localzone-fips-f14
- as: aws-ipi-disconnected-mtu-localzone-fips-f28-destructive
- as: aws-ipi-localzone-byo-subnet-sdn-f14
- as: aws-ipi-localzone-byo-subnet-sdn-f28-destructive
- as: aws-ipi-localzone-fips-f14
- as: aws-ipi-localzone-fips-f28-destructive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yunjiang29 yunjiang29 deleted the lz-phase2 branch January 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@gpei gpei Awaiting requested review from gpei

Assignees

@jianlinliu jianlinliu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yunjiang29 @openshift-ci-robot @jianlinliu @liangxia @openshift-merge-robot