Adapt config applying jobs & docs for applyconfig #4147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Member
Author
openshift-ci-robot
requested review from
bbguimaraes,
droslean,
hongkailiu and
stevekuznetsov
petr-muller
force-pushed
the
applyconfig-jobs
branch
from
c59546e to
41ccdd3
Compare
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
openshift-ci-robot
added
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
petr-muller
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
@petr-muller: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4143
Makefileand deletecore-services/Makefile(not needed, yay!)dry-coreis no longer a ci-operator job, because it needs to run asconfig-updater. It still runs from the repo, in the future we'll want to build and image and runapplyconfigfrom there to be entirely safe.