Skip to content

openstack/gather: add support for volumes#41450

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:osp_gather_vols
Jul 20, 2023
Merged

openstack/gather: add support for volumes#41450
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:osp_gather_vols

Conversation

@EmilienM
Copy link
Member

@EmilienM EmilienM commented Jul 19, 2023

Gather volumes infos as well, for debug purposes.

@openshift-ci openshift-ci bot requested review from dulek and mdbooth July 19, 2023 19:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@EmilienM
Copy link
Member Author

EmilienM commented Jul 19, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-kuryr

@EmilienM
Copy link
Member Author

EmilienM commented Jul 20, 2023

/hold
not working yet

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@EmilienM: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build08-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi01-dry
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test supplemental-ci-images-mapping-files
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/retest e2e-openstack-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
openstack/gather: add support for volumes
d8bb6e5 
Gather volumes infos as well, for debug purposes.
@EmilienM
Copy link
Member Author

EmilienM commented Jul 20, 2023

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-kuryr

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 20, 2023

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.12-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.11-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.10-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.9-e2e-openstack-csi-cinder openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.12-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.11-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.10-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.9-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.15-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.14-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.13-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.12-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.11-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.10-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.9-e2e-openstack openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-openstack openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-openstack-parallel openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-openstack openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-openstack-parallel openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-openstack openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-openstack-parallel openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-openstack openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-openstack-parallel openshift/cluster-storage-operator presubmit Registry content changed

A total of 566 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@EmilienM
Copy link
Member Author

EmilienM commented Jul 20, 2023

/pj-rehearse pull-ci-openshift-installer-master-e2e-openstack-kuryr

@EmilienM EmilienM mentioned this pull request Jul 20, 2023
Merged
7 tasks
mandre
mandre reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance. Let's wait for CI to return so see if it was able to gather the volume info.

mandre
mandre reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The step was able to capture volumes info on the last run:
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/41450/rehearse-41450-pull-ci-openshift-installer-master-e2e-openstack-kuryr/1681851517339963392/artifacts/e2e-openstack-kuryr/openstack-gather/artifacts/openstack_volumes.log

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Member Author

EmilienM commented Jul 20, 2023

/hold cancel
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 20, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-kuryr d8bb6e5 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-kuryr
ci/rehearse/openshift/installer/master/e2e-openstack-kuryr d8bb6e5 link unknown /pj-rehearse pull-ci-openshift-installer-master-e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 75f263c into openshift:master Jul 20, 2023
@EmilienM EmilienM deleted the osp_gather_vols branch July 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@mdbooth mdbooth Awaiting requested review from mdbooth

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EmilienM @openshift-ci-robot @mandre @openshift-merge-robot