Skip to content

openstack: deploy ctlplane with rootVolume too#41386

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:rootvol_ctlplane
Jul 19, 2023
Merged

openstack: deploy ctlplane with rootVolume too#41386
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:rootvol_ctlplane

Conversation

@EmilienM
Copy link
Member

When testing the rootVolume in a deployment, also include the
controlplane, so later this can be tested by the CPMS.

This might have a negative impact on the performance, since etcd will be
on a cinder volume attached via Ceph, and we know the performance
impact, so we need to be careful about this change.

When testing the rootVolume in a deployment, also include the
controlplane, so later this can be tested by the CPMS.

This might have a negative impact on the performance, since etcd will be
on a cinder volume attached via Ceph, and we know the performance
impact, so we need to be careful about this change.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-master-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.15-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.15-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.14-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.14-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.13-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.13-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.12-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.12-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.11-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.11-e2e-openstack-nfv-hwoffload openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.10-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-sriov-network-operator-release-4.9-e2e-openstack-nfv openshift/sriov-network-operator presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.15-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.14-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.12-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.10-e2e-openstack openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.15-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.14-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.12-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-intel openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.11-e2e-openstack-nfv-mellanox openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-master-e2e-openstack-proxy openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.15-e2e-openstack-proxy openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.14-e2e-openstack-proxy openshift/machine-api-provider-openstack presubmit Registry content changed
pull-ci-openshift-machine-api-provider-openstack-release-4.13-e2e-openstack-proxy openshift/machine-api-provider-openstack presubmit Registry content changed

A total of 566 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from MaysaMacedo and mdbooth July 18, 2023 19:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.14-e2e-openstack-kuryr

@EmilienM
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@EmilienM
Copy link
Member Author

/hold cancel

/cc mandre
are you fine with it? this should only have effects on the Kuryr job now and the CPMS job running in az0.

@openshift-ci openshift-ci bot requested a review from mandre July 18, 2023 23:31
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@mandre
Copy link
Member

mandre commented Jul 19, 2023

/cc mandre are you fine with it? this should only have effects on the Kuryr job now and the CPMS job running in az0.

From https://github.com/openshift/release/blob/29c1c67/ci-operator/step-registry/openstack/conf/resourcenames/openstack-conf-resourcenames-commands.sh#L37-L45, I can see it's only affecting jobs that run on the openstack-kuryr or openstack-vh-mecha-az0 platforms since that's where we define compute AZs.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Jul 19, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@EmilienM: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9ec63e8 into openshift:master Jul 19, 2023
@EmilienM EmilienM deleted the rootvol_ctlplane branch July 19, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants