Skip to content

Conversation

@bradmwilliams
Copy link
Contributor

Reverting a change, from #39897, that's causing the release-controller validation script to silently fail since it was introduced:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/39897/pull-ci-openshift-release-master-release-controller-config/1666153420840505344

While I appreciate the rationale behind the change we specifically added the "ERROR" verbiage, to this test, to tell you exactly what needs to be done to address the problem. Sure, a git diff might be nice to see, but ultimately it's the make release-controllers that will fix this issue.

ERROR: This check enforces that Release Controller configuration files are generated
ERROR: correctly. We have automation in place that generates these configs and
ERROR: any changes must be included in your pull-request.
ERROR: Run the following command to re-generate the release controller configurations, run:
ERROR: $ make release-controllers
ERROR: The following differences were found:

@wking If this is truly a show-stopper, then let me know and we'll make the necessary changes to support it.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 18, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bradmwilliams: no rehearsable tests are affected by this change

@openshift-ci openshift-ci bot requested review from bbguimaraes and smg247 July 18, 2023 18:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@bradmwilliams: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jupierce
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradmwilliams, jupierce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5c6f270 into openshift:master Jul 18, 2023
@bradmwilliams bradmwilliams deleted the rc-silent-failure-fix branch July 18, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants