Reverting logic that causes validation to silently fail #41384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting a change, from #39897, that's causing the release-controller validation script to silently fail since it was introduced:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/39897/pull-ci-openshift-release-master-release-controller-config/1666153420840505344
While I appreciate the rationale behind the change we specifically added the "ERROR" verbiage, to this test, to tell you exactly what needs to be done to address the problem. Sure, a git diff might be nice to see, but ultimately it's the
make release-controllersthat will fix this issue.@wking If this is truly a show-stopper, then let me know and we'll make the necessary changes to support it.