Skip to content

Conversation

@vrutkovs
Copy link
Contributor

This adds new functions in installer template and two optional tests which run on request. This is a replacement for restore-cluster-state and recover-from-etcd-quorum-loss functions in the template.

Tests themselves are added in openshift/origin#23208, this PR is required to add new optional tests to Origin

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2019
@vrutkovs
Copy link
Contributor Author

/cc @deads2k @smarterclayton

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/origin/master/e2e-dr-snapshot-tests 511db8f link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-dr-quorum-tests 511db8f link /test pj-rehearse
ci/prow/pj-rehearse 511db8f link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@openshift-merge-robot
Copy link
Contributor

/test core-valid
/test core-dry

@deads2k
Copy link
Contributor

deads2k commented Jun 19, 2019

optional tag looks correct

/approve

you're quite red, but I think it'll pass...

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, deads2k, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 51c51cd into openshift:master Jun 19, 2019
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Updated the following 5 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

This adds new functions in installer template and two optional tests which run on request. This is a replacement for restore-cluster-state and recover-from-etcd-quorum-loss functions in the template.

Tests themselves are added in openshift/origin#23208, this PR is required to add new optional tests to Origin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants