Skip to content

templates/openshift/installer: update setup for installer to gather logs on bootstrap failure #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 12, 2019
Merged

templates/openshift/installer: update setup for installer to gather logs on bootstrap failure #4009

openshift-merge-robot merged 1 commit into from
Jun 12, 2019

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Jun 7, 2019 •
edited
Loading

With installer PR 1, the installer will automatically gather the logs from bootstrap in case of bootstrap failure.
It uses the ~/.ssh directlory to load the private SSH keys for authentication, when not specifically invoked using gather bootstrap --key <>

/cc @smarterclayton
^^-- because we was concerned with changes to templates wrt 4.2 and 4.1.x
/cc @wking

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2019
@abhinavdahiya
templates/openshift/installer: update setup for installer to gather l…
5afda2b 
…ogs on bootstrap failure

With installer PR [1], the installer will automatically gather the logs from bootstrap in case of bootstrap failure.
It uses the `~/.ssh` directlory to load the private SSH keys for authentication, when not specifically invoked using `gather bootstrap --key <>`

[1]: openshift/installer#1822
@abhinavdahiya
Copy link
Contributor Author

abhinavdahiya commented Jun 11, 2019

ping @smarterclayton @wking

@wking
Copy link
Member

wking commented Jun 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 82f176f into openshift:master Jun 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 12, 2019

@abhinavdahiya: Updated the following 6 configmaps:

  • prow-job-cluster-launch-installer-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-src configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-src.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-src.yaml
  • prow-job-cluster-launch-installer-console configmap in namespace ci using the following files:
    • key cluster-launch-installer-console.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-console.yaml
  • prow-job-cluster-launch-installer-console configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-console.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-console.yaml
  • prow-job-cluster-launch-installer-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

With installer PR 1, the installer will automatically gather the logs from bootstrap in case of bootstrap failure.
It uses the ~/.ssh directlory to load the private SSH keys for authentication, when not specifically invoked using gather bootstrap --key <>

/cc @smarterclayton
^^-- because we was concerned with changes to templates wrt 4.2 and 4.1.x
/cc @wking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wking wking Awaiting requested review from wking

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinavdahiya @wking @openshift-ci-robot @openshift-merge-robot