Skip to content

Comments

HOSTEDCP-966: hypershift: mco: make hypershift e2e required#39854

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjenning:mco-require-hypershift
May 31, 2023
Merged

HOSTEDCP-966: hypershift: mco: make hypershift e2e required#39854
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sjenning:mco-require-hypershift

Conversation

@sjenning
Copy link
Contributor

Hypershift e2e is now blocking on ci release stream.

We should block breaking changes from merging for operators/components running in the Hypershift control plane.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 30, 2023

@sjenning: This pull request references HOSTEDCP-966 which is a valid jira issue.

Details

In response to this:

Hypershift e2e is now blocking on ci release stream.

We should block breaking changes from merging for operators/components running in the Hypershift control plane.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 30, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sjenning: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-hypershift openshift/machine-config-operator presubmit Presubmit changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-hypershift openshift/machine-config-operator presubmit Presubmit changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-hypershift openshift/machine-config-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sjenning
Copy link
Contributor Author

cc @yuqi-zhang

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@cgwalters
Copy link
Member

/pj-rehearse auto-ack

@sjenning
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.15/e2e-hypershift 72cc3a1 link unknown /pj-rehearse pull-ci-openshift-machine-config-operator-release-4.15-e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 09d4cc8 into openshift:master May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@sjenning: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.14.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.15.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.15.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.14-presubmits.yaml
  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-release-4.15-presubmits.yaml
Details

In response to this:

Hypershift e2e is now blocking on ci release stream.

We should block breaking changes from merging for operators/components running in the Hypershift control plane.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

subbarao-meduri pushed a commit to subbarao-meduri/release that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants