Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Jun 5, 2019

Fix a typo in quorum loss scenario - it was using assets dir without a backup. /var/lib/etcd/ should be used instead

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jun 5, 2019

/cc @hexfusion @wking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it to trigger the test - this commit would be removed later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK gotcha I find this a nice little trick git commit --amend --no-edit :)

@hexfusion
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@vrutkovs vrutkovs force-pushed the dr-snapshot-var-lib branch from c3ec3a3 to 9cc38e5 Compare June 5, 2019 21:12
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hexfusion, vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: staebler

If they are not already assigned, you can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/generated-config 9cc38e5 link /test generated-config
ci/prow/ordered-prow-config 9cc38e5 link /test ordered-prow-config
ci/rehearse/openshift/installer/master/e2e-etcd-quorum-loss 9cc38e5 link /test pj-rehearse
ci/prow/pj-rehearse 9cc38e5 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

echo "Restore single etcd - /usr/local/bin/etcd-snapshot-restore.sh"
bastion_ssh core@${SURVIVING_MASTER_NODE} 'sudo -i /bin/bash -x /usr/local/bin/etcd-snapshot-restore.sh /root/assets/backup/etcd/member/snap/db $(cat /tmp/etcd_connstring)'
bastion_ssh core@${SURVIVING_MASTER_NODE} 'sudo -i /bin/bash -x /usr/local/bin/etcd-snapshot-restore.sh /var/lib/etcd/member/snap/db $(cat /tmp/etcd_connstring)'
Copy link
Contributor

@hexfusion hexfusion Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think /root/assets/backup/etcd... is actually right. openshift/machine-config-operator#804 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/close

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants