Skip to content

Conversation

@osherdp
Copy link
Contributor

@osherdp osherdp commented Mar 20, 2023

Returning the job now that a workaround has been implemented in openshift-metal3/dev-scripts#1519.

@openshift-ci-robot
Copy link
Contributor

@osherdp: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-service-master-e2e-agent-compact openshift/assisted-service presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from jhernand and slaviered March 20, 2023 09:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Mar 20, 2023

/cc @andfasano @eranco74 @eliorerz

@andfasano
Copy link
Contributor

/hold

The e2e-agent-compact it's currently the only job that verifies the generation of the agent-installer-api-server image in the master ci-operator configuration, shipped in the OCP release payload and fundamental for the agent-based installer workflow, so it should be always run in a blocking manner.

A fix is available but currently a more generic issue at rhcos level is preventing its success (see https://issues.redhat.com/browse/OCPBUGS-8036), which is independent by the current repo, since the related rhcos image with the fix seems not be yet available on the 4.14 branch.

A workaround has been pushed to temporary addressed that openshift-metal3/dev-scripts#1519: if successfull, the previous job configuration could be fully restored

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Mar 20, 2023

currently

ack. after the dev-scripts workaround merges we can fully restore the configuration
thanks!

@osherdp osherdp force-pushed the feature/re-add-agent-compact-job branch from 78968cb to 18a8bb5 Compare March 20, 2023 12:40
@osherdp osherdp changed the title re-add the job as one that doesn't run by default re-add the e2e-agent-compact job Mar 20, 2023
@osherdp osherdp force-pushed the feature/re-add-agent-compact-job branch from 18a8bb5 to 9b77f89 Compare March 20, 2023 12:41
@eranco74
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
@andfasano
Copy link
Contributor

Removing the hold since openshift-metal3/dev-scripts#1519 merged

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Mar 20, 2023

/pj-rehearse auto-ack

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Mar 21, 2023

/pj-rehearse auto-ack

@andfasano
Copy link
Contributor

/pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-compact

1 similar comment
@andfasano
Copy link
Contributor

/pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-compact

@andfasano
Copy link
Contributor

@osherdp the bot wiped out the dev-scripts image meanwhile, it needs to be re-added:

 dev-scripts:
    name: test
    namespace: ocp-kni
    tag: dev-scripts

Returning the job now that a workaround has been implemented in
openshift-metal3/dev-scripts#1519.
@osherdp osherdp force-pushed the feature/re-add-agent-compact-job branch from 9b77f89 to bd60483 Compare March 21, 2023 16:33
@osherdp
Copy link
Contributor Author

osherdp commented Mar 21, 2023

@osherdp the bot wiped out the dev-scripts image meanwhile, it needs to be re-added:

 dev-scripts:
    name: test
    namespace: ocp-kni
    tag: dev-scripts

ack. re-added the base image
thanks!

@osherdp
Copy link
Contributor Author

osherdp commented Mar 21, 2023

/pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-compact

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@osherdp
Copy link
Contributor Author

osherdp commented Mar 21, 2023

/pj-rehearse pull-ci-openshift-assisted-service-master-e2e-agent-compact

@eranco74
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Contributor Author

osherdp commented Mar 21, 2023

/pj-rehearse ack
🎉

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4123c36 into openshift:master Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@osherdp: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-service-master.yaml using file ci-operator/config/openshift/assisted-service/openshift-assisted-service-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-service-master-presubmits.yaml using file ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-master-presubmits.yaml
Details

In response to this:

Returning the job now that a workaround has been implemented in openshift-metal3/dev-scripts#1519.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
Returning the job now that a workaround has been implemented in
openshift-metal3/dev-scripts#1519.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants