-
Notifications
You must be signed in to change notification settings - Fork 2.1k
remove timeout,grace_period from jobs, and fix azure Jobs #3713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove timeout,grace_period from jobs, and fix azure Jobs #3713
Conversation
ce0cd84 to
c83e9c9
Compare
c83e9c9 to
62898a3
Compare
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@petr-muller: Updated the following 6 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…bmits: Remove some timeout clobbers Like 4372624 (remote timeout,grace_period from jobs, 2019-05-07, openshift#3713) and 62898a3 (Fixup few remaining fields, 2019-05-08, openshift#3713). This gives us the usual grace period and timeout for OpenShift tests, instead of clobbering the OpenShift values and falling back to the generic Prow defaults.
Needed after openshift/ci-operator-prowgen#157
Same like #3706 but with few more necessary fixes.