Skip to content

Conversation

@cgwalters
Copy link
Member

It's nice to have it available, but in practice it's not super useful for the MCO, because these -upgrade tests just do a synthetic update and not an OS upgrade. We want to be using the payload tests.

We'll keep this (it's cheaper and maybe useful sometimes) but make it always_run=false so it's not run by default and blocking.

It's nice to have it available, but in practice it's not super
useful for the MCO, because these `-upgrade` tests just do
a *synthetic* update and not an OS upgrade.  We want to be using
the payload tests.

We'll keep this (it's cheaper and maybe useful sometimes)
but make it `always_run=false` so it's not run by default and blocking.
@openshift-ci openshift-ci bot requested review from jkyros and sinnykumari March 4, 2023 14:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 4, 2023
@openshift-ci-robot
Copy link
Contributor

@cgwalters: no rehearsable tests are affected by this change

@sinnykumari
Copy link
Contributor

Agree. Thanks for the PR.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e8d4b89 into openshift:master Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@cgwalters: Updated the job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
Details

In response to this:

It's nice to have it available, but in practice it's not super useful for the MCO, because these -upgrade tests just do a synthetic update and not an OS upgrade. We want to be using the payload tests.

We'll keep this (it's cheaper and maybe useful sometimes) but make it always_run=false so it's not run by default and blocking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants