Skip to content

SPLAT-636: setting Local Zone labels to machine.openshift.io namespace #36904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 3, 2023
Merged

SPLAT-636: setting Local Zone labels to machine.openshift.io namespace #36904

openshift-merge-robot merged 1 commit into from
Mar 3, 2023

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 3, 2023 •
edited
Loading

Setting the correct labels according to the most recent changes/definition.

openshift/installer#6371

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023

@mtulio: No Jira issue with key installer-6371 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Setting the correct labels according to the most recent changes/definition.

openshift/installer#6371 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023

@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-aws-1 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-ec-4.13-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-sdn-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-disconnected-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-ec-4.13-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-sdn-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-ec-4.13-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-disconnected-network-mtu-localzone-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-disconnected-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-sdn-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-sdn-p2-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-network-mtu-localzone-p3-f28-destructive N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio mtulio changed the title fix/installer-6371: Setting labels to machine.openshift.io namespace SPLAT-636: setting Local Zone labels to machine.openshift.io namespace Mar 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-636 which is a valid jira issue.

Details

In response to this:

Setting the correct labels according to the most recent changes/definition.

openshift/installer#6371 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deepsm007 and neisw March 3, 2023 02:43
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-636 which is a valid jira issue.

Details

In response to this:

Setting the correct labels according to the most recent changes/definition.

openshift/installer#6371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio
Copy link
Contributor Author

mtulio commented Mar 3, 2023

@yunjiang29 ptal?

@yunjiang29
Copy link
Contributor

yunjiang29 commented Mar 3, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-aws-ipi-network-mtu-localzone-p2-f14

@yunjiang29
Copy link
Contributor

yunjiang29 commented Mar 3, 2023

/lgtm

@yunjiang29
Copy link
Contributor

yunjiang29 commented Mar 3, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit 922968e into openshift:master Mar 3, 2023
@mtulio mtulio deleted the installer-6371-fix-labels branch March 3, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@neisw neisw Awaiting requested review from neisw

Assignees

@yunjiang29 yunjiang29

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtulio @openshift-ci-robot @yunjiang29 @openshift-merge-robot