Skip to content

Several fixes for UPI (vsphere) template #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrutkovs wants to merge 3 commits into from
Closed

Several fixes for UPI (vsphere) template #3593

vrutkovs wants to merge 3 commits into from

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Apr 25, 2019

Based on #3587

  • rework CSR approve and image patching loops to stop when /tmp/exit is created
  • use UPI-specific path to terraform.state
  • collect info when bootstrap has failed

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Apr 26, 2019

/test pj-rehearse

@vrutkovs vrutkovs force-pushed the vsphere-fixes branch 3 times, most recently from a59ef24 to 14cddc8 Compare April 29, 2019 09:07
@droslean
Copy link
Member

droslean commented Apr 29, 2019

/test pj-rehearse

@droslean
Copy link
Member

droslean commented May 2, 2019

/test pj-rehearse

@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 3, 2019 

Failing tests:

[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]

ail [github.com/openshift/origin/test/extended/operators/cluster.go:118]: Expected
    <[]string | len:1, cap:1>: [
        "Pod openshift-sdn/sdn-controller-9vwv2 is not healthy: conflict, name \"k8s_sdn-controller_sdn-controller-9vwv2_openshift-sdn_71ba5c81-6cc5-11e9-afb3-0050569b88e3_2\" already reserved for ctr \"9141bf0c14fb04c719b7600769a58b5915a92126457de8e5adf950d34344a399\"",
    ]
to be empty

/test pj-rehearse

@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 6, 2019

Same flake
/test pj-rehearse

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 17, 2019

/test pj-rehearse

@vrutkovs vrutkovs force-pushed the vsphere-fixes branch 2 times, most recently from 0512e7e to f19b358 Compare May 24, 2019 08:47
@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 30, 2019

/test pj-rehearse

@vrutkovs
Copy link
Contributor Author

vrutkovs commented May 30, 2019 •
edited
Loading 

Failing tests:

[cli] oc adm must-gather runs successfully [Suite:openshift/conformance/parallel]
[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: dir-bindmounted] [Testpattern: Pre-provisioned PV (ntfs)][sig-windows] volumes should allow exec of files on the volume [Suite:openshift/conformance/parallel] [Suite:k8s]

The former looks like a common issue on vsphere (filed openshift/must-gather#92), the latter seems to be flake

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Jan 15, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 12, 2020

@vrutkovs: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 12, 2020

@vrutkovs: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 26, 2020

/uncc @abhinavdahiya

@openshift-ci-robot openshift-ci-robot removed the request for review from abhinavdahiya May 26, 2020 18:00
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2020

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/master/e2e-vsphere f19b3588912dc1b87f6ef11112d72218e3c7edcd link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-upi f19b3588912dc1b87f6ef11112d72218e3c7edcd link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi 28dd6bc link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-proxy 28dd6bc link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-vsphere 28dd6bc link /test pj-rehearse
ci/prow/pj-rehearse 28dd6bc link /test pj-rehearse
ci/prow/generated-cluster 28dd6bc link /test generated-cluster
ci/prow/ci-operator-config 28dd6bc link /test ci-operator-config
ci/prow/ci-operator-config-metadata 28dd6bc link /test ci-operator-config-metadata
ci/build-farm/app-ci-config-dry 28dd6bc link /test app-ci-config-dry
ci/build-farm/build02-dry 28dd6bc link /test build02-dry
ci/prow/release-controller-config 28dd6bc link /test release-controller-config
ci/prow/step-registry-metadata 28dd6bc link /test step-registry-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @droslean @openshift-ci-robot @abhinavdahiya @wking