Skip to content

configs/installer: increase the resource limits for all image builds #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 25, 2019
Merged

configs/installer: increase the resource limits for all image builds #3588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ci-operator/config/openshift/installer/openshift-installer-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,36 @@ resources:
requests:
cpu: 100m
memory: 200Mi
installer:
limits:
memory: 9Gi
requests:
cpu: "3"
memory: 5Gi
upi-installer:
Copy link
Member

@wking wking Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how these keys tie us to the openshift-install compilation step. Maybe we want to restore just the bin key I seem to have accidentally removed in 3f2f01c (#1677)? Which was maybe originally from 0b1cdda (#891)?

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using it similar to unit https://github.com/openshift/release/pull/3588/files/c589ac71aed9634a04298e1b3126fab5b52a281a#diff-f9121dca038210d2d38e2713d851b4efR96

Copy link
Member

@wking wking Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using it similar to unit

Yup, although I'd be surprised if wee needed 5 GiB memory for our unit tests. And I'm still not clear how these are supposed to work, but I worry that this line is getting limits/requests for our UPI jobs (which are probably fine already) instead of for the compilation job that the UPI tests depend on. Does the CI output show this worked?

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the CI output show this worked?

yes the build jobs for rehearse had the correct resource requests/limits for build pods.

limits:
memory: 9Gi
requests:
cpu: "3"
memory: 5Gi
libvirt-installer:
limits:
memory: 9Gi
requests:
cpu: "3"
memory: 5Gi
openstack-installer:
limits:
memory: 9Gi
requests:
cpu: "3"
memory: 5Gi
installer-artifacts:
limits:
memory: 9Gi
requests:
cpu: "3"
memory: 5Gi
unit:
limits:
memory: 9Gi
Expand Down