Skip to content

IPI private cluster on alibabacloud - insert the VPC settings in install-config #35061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 3, 2023
Merged

IPI private cluster on alibabacloud - insert the VPC settings in install-config #35061

openshift-merge-robot merged 1 commit into from
Jan 3, 2023

Conversation

@jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Dec 27, 2022 •
edited
Loading

Cont. to #31664.

  1. The VPC settings, i.e. platform.alibabacloud.vpcID and platform.alibabacloud.vswitchIDs, should be inserted into install-config.yaml, so added step ipi-conf-alibabacloud-provisioned-network accordingly.
  2. Update step gather-alibabacloud-console to enable client proxy when applicable.
  3. Update step alibabacloud-provision-vpc to sleep a bit after AssociateEipAddress, and add stage logs.
  4. Update step alibabacloud-provision-bastionhost to sleep a bit more after RunInstances, and add stage logs.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 27, 2022

@jianli-wei: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-alibaba-cloud-master-e2e-alibabacloud openshift/cloud-provider-alibaba-cloud presubmit Registry content changed
pull-ci-openshift-cloud-provider-alibaba-cloud-release-4.14-e2e-alibabacloud openshift/cloud-provider-alibaba-cloud presubmit Registry content changed
pull-ci-openshift-cloud-provider-alibaba-cloud-release-4.13-e2e-alibabacloud openshift/cloud-provider-alibaba-cloud presubmit Registry content changed
pull-ci-openshift-cloud-provider-alibaba-cloud-release-4.12-e2e-alibabacloud openshift/cloud-provider-alibaba-cloud presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-alibabacloud openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-alibabacloud openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.13-e2e-alibabacloud openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-master-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.14-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.13-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.12-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.11-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-cloud-csi-driver-release-4.10-e2e-alibabacloud-disk-csi openshift/alibaba-cloud-csi-driver presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-master-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-release-4.14-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-release-4.13-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-release-4.12-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-release-4.11-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-alibaba-disk-csi-driver-operator-release-4.10-e2e-alibabacloud-disk-csi openshift/alibaba-disk-csi-driver-operator presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-alibaba openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.14-e2e-alibaba openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.13-e2e-alibaba openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.12-e2e-alibaba openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.11-e2e-alibaba openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.10-e2e-alibaba openshift/installer presubmit Registry content changed
periodic-ci-openshift-release-master-nightly-4.10-e2e-alibaba N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-alibaba-csi N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.10-e2e-alibaba-csi N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.11-e2e-alibaba N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-alibaba-ovn N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-alibaba-csi N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.10-installer-rehearse-alibabacloud N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.11-e2e-alibaba-csi N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 27, 2022

/test pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 27, 2022

@jianli-wei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi-arch-gen-valid
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test pj-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 27, 2022

/pj-rehearse

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 27, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 27, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 27, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 28, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 28, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 28, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 28, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 28, 2022

/assign @jianlinliu @gpei

@jianli-wei jianli-wei force-pushed the ali-private branch 3 times, most recently from dcd9205 to 5e58fd4 Compare December 29, 2022 04:02
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 29, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 29, 2022

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.12-installer-rehearse-alibabacloud

@jianlinliu
Copy link
Contributor

jianlinliu commented Dec 29, 2022

/lgtm

@jianlinliu
Copy link
Contributor

jianlinliu commented Dec 29, 2022

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2022
@jianli-wei
Copy link
Contributor Author

jianli-wei commented Dec 29, 2022

/assign @fabianofranz

@fabianofranz
Copy link
Member

fabianofranz commented Jan 3, 2023

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

@jianli-wei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e9b9c67 into openshift:master Jan 3, 2023
@jianli-wei jianli-wei deleted the ali-private branch January 4, 2023 03:25
jianli-wei added a commit to jianli-wei/release that referenced this pull request Jan 6, 2023
@jianli-wei
insert vpc info (openshift#35061)
81db073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianofranz fabianofranz Awaiting requested review from fabianofranz

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

1 more reviewer

@jianlinliu jianlinliu jianlinliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fabianofranz fabianofranz

@jianlinliu jianlinliu

@gpei gpei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jianli-wei @openshift-ci-robot @jianlinliu @fabianofranz @gpei @openshift-merge-robot