-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add disaster recovery template #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice start, knowing that we'll have this and a cluster state rollback should we name the file/job so that it's clear this is specific to the infrastructure replacement DR scenario? Otherwise if it works as advertised I think we've completed the first step for the first scenario. |
ebc11c1 to
80c72c2
Compare
|
Renamed to |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdodson, vrutkovs If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit with the filename, I think we can assume IPI and only call out UPI in UPI templates (which is our current pattern), so I'd prefer cluster-disaster-control-plane.yaml.
aecb327 to
2bb056c
Compare
|
New changes are detected. LGTM label has been removed. |
|
Renamed and squashed down. |
| done | ||
|
|
||
| echo "Destroy two masters" | ||
| oc --request-timeout=5s -n openshift-machine-api delete machines ${MASTER_MACHINES_TO_REMOVE[@]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to address this without a new template would be to drop all of this new stuff into a shell function, and jobs that wanted to trigger it could use:
- name: TEST_COMMAND
value: |
destroy-some-control-plane-machines
TEST_SUITE=openshift/conformance/parallel run-testsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say drop this stuff into a new shell function, are you saying the new shell function would be added to an already existing template, like cluster-launch-installer-e2e.yaml or another template? That makes sense, but I wanted to make sure that is your point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say drop this stuff into a new shell function, are you saying the new shell function would be added to an already existing template, like cluster-launch-installer-e2e.yaml or another template?
Yup, right here, with:
function destroy-some-control-plane-machines() {
...bla bla...
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #3572 to play with this idea
|
Closed in favor of #3572 |
Create a new template which would test cluster disaster recovery when 2 masters are down.
TODO: