Provide ARM instance type explicitly #34179
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
@yunjiang29: the following rehearsable tests have been affected by this change:
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
yunjiang29
force-pushed
the
fix-arm-instance-type-issue
branch
from
f431246 to
6956cff
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Hi @yunjiang29 I'm ok with any of the solutions you propose. It's good enough just to specify the instance types to use (as we do in flexy). I'd say the 2nd proposal is the less risky to avoid changing too many x86 prow configs. Instead, having the x86 instance types explicitly called out is a "nice-to-have" for the others that create new profiles: they would see very similar configs in both the architectures' prow configs. |
|
@aleskandro thanks for your feedback. |
|
/pj-rehearse |
|
Does this influnce dev's jobs? they use |
I guess no, if nothing set for |
Correct. The types are added in job config level, which is for QE only. |
|
Some jobs' installation get passed, the change works. @kuiwang02 can you approve this PR? thanks. |
please request qe-productivity team to approve it. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liangxia, yunjiang29 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
@yunjiang29: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yunjiang29: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
8 participants
Background:
m6awas set as the default instance type family by Change ephemeral clusters to use more cost efficient m6a family #31684, this caused theInsufficientInstanceCapacity m6a.xlarge capacityissue, so Prevent frequent m6a capacity overruns #31828 was applied.-provisionchain, these default values are also used by arm cluster, this PR is trying to fix this issue.there are some options for this fix:
I choose 2) in this PR because of the fewer code changes.
@aleskandro @lwan-wanglin @jianlinliu, any comments/ideas on this?