Skip to content

DPTP-376: Rename vsphere credentials #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 9, 2019
Merged

DPTP-376: Rename vsphere credentials #3397

openshift-merge-robot merged 1 commit into from
Apr 9, 2019

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Apr 9, 2019

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2019
@vrutkovs
Copy link
Contributor

vrutkovs commented Apr 9, 2019

Looks good, I'll drop this part from #3305 once its merged and applied

vrutkovs
vrutkovs approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petr-muller
Copy link
Member Author

petr-muller commented Apr 9, 2019

Looks good, I'll drop this part from #3305 once its merged and applied

You can /lgtm this too, np. I haven't noticed you have this in your PR, but it's better to merge it separately so that BW, sync script and the actual secret stay in sync.

@droslean
Copy link
Member

droslean commented Apr 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [droslean,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dfa0cb6 into openshift:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@droslean droslean

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petr-muller @vrutkovs @droslean @openshift-ci-robot @openshift-merge-robot